Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
W
wendelin.core
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Joshua
wendelin.core
Commits
d134ee44
Commit
d134ee44
authored
Mar 23, 2020
by
Kirill Smelkov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
X FUSE lookup deadlock should be hopefully fixed
parent
9ff5ed32
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
1 deletion
+3
-1
wcfs/wcfs.go
wcfs/wcfs.go
+3
-1
No files found.
wcfs/wcfs.go
View file @
d134ee44
...
@@ -1043,7 +1043,7 @@ func (f *BigFile) invalidateBlk(ctx context.Context, blk int64) (err error) {
...
@@ -1043,7 +1043,7 @@ func (f *BigFile) invalidateBlk(ctx context.Context, blk int64) (err error) {
func
()
{
func
()
{
// store retrieved data back to OS cache for file @<rev>/file[blk]
// store retrieved data back to OS cache for file @<rev>/file[blk]
//
//
//
FIXME
there is deadlock here:
//
XXX
there is deadlock here:
//
//
// T1: Lookup "head"
// T1: Lookup "head"
// -> nodefs.rawBridge.lookupLock.Lock
// -> nodefs.rawBridge.lookupLock.Lock
...
@@ -1056,6 +1056,8 @@ func (f *BigFile) invalidateBlk(ctx context.Context, blk int64) (err error) {
...
@@ -1056,6 +1056,8 @@ func (f *BigFile) invalidateBlk(ctx context.Context, blk int64) (err error) {
//
//
// see https://github.com/hanwen/go-fuse/commit/d0fca860
// see https://github.com/hanwen/go-fuse/commit/d0fca860
// for when rawBridge.lookupLock was introduced.
// for when rawBridge.lookupLock was introduced.
//
// -> should be fixed: https://review.gerrithub.io/c/hanwen/go-fuse/+/487809
blkrev
,
_
:=
f
.
LastBlkRev
(
ctx
,
blk
,
f
.
head
.
zconn
.
At
())
blkrev
,
_
:=
f
.
LastBlkRev
(
ctx
,
blk
,
f
.
head
.
zconn
.
At
())
frev
,
funlock
,
err
:=
groot
.
lockRevFile
(
blkrev
,
f
.
zfile
.
POid
())
frev
,
funlock
,
err
:=
groot
.
lockRevFile
(
blkrev
,
f
.
zfile
.
POid
())
if
err
!=
nil
{
if
err
!=
nil
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment