Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kazuhiko Shiozaki
gitlab-ce
Commits
5a3237fd
Commit
5a3237fd
authored
Dec 20, 2015
by
Jared Szechy
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix build coverage regex.
Added a spec for regex captures as well. Fixes #2644
parent
05e0b6d0
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
1 deletion
+8
-1
app/models/ci/build.rb
app/models/ci/build.rb
+2
-1
spec/models/build_spec.rb
spec/models/build_spec.rb
+6
-0
No files found.
app/models/ci/build.rb
View file @
5a3237fd
...
@@ -170,7 +170,8 @@ module Ci
...
@@ -170,7 +170,8 @@ module Ci
def
extract_coverage
(
text
,
regex
)
def
extract_coverage
(
text
,
regex
)
begin
begin
matches
=
regex
.
match
(
text
).
to_a
.
last
matches
=
text
.
scan
(
Regexp
.
new
(
regex
)).
last
matches
=
matches
.
last
if
matches
.
kind_of?
(
Array
)
coverage
=
matches
.
gsub
(
/\d+(\.\d+)?/
).
first
coverage
=
matches
.
gsub
(
/\d+(\.\d+)?/
).
first
if
coverage
.
present?
if
coverage
.
present?
...
...
spec/models/build_spec.rb
View file @
5a3237fd
...
@@ -189,6 +189,12 @@ describe Ci::Build, models: true do
...
@@ -189,6 +189,12 @@ describe Ci::Build, models: true do
it
{
is_expected
.
to
eq
(
98.29
)
}
it
{
is_expected
.
to
eq
(
98.29
)
}
end
end
context
'using a regex capture'
do
subject
{
build
.
extract_coverage
(
'TOTAL 9926 3489 65%'
,
'TOTAL\s+\d+\s+\d+\s+(\d{1,3}\%)'
)
}
it
{
is_expected
.
to
eq
(
65
)
}
end
end
end
describe
:variables
do
describe
:variables
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment