Commit bbfa4a77 authored by Jacob Vosmaer's avatar Jacob Vosmaer

Always set last_fetched_at in NotesFinder spec

parent 0b615eb0
...@@ -12,25 +12,25 @@ describe NotesFinder do ...@@ -12,25 +12,25 @@ describe NotesFinder do
end end
describe :execute do describe :execute do
let(:params) { { target_id: commit.id, target_type: 'commit', last_fetched_at: 1.hour.ago } }
before do before do
note1 note1
note2 note2
end end
it 'should find all notes' do it 'should find all notes' do
params = { target_id: commit.id, target_type: 'commit' }
notes = NotesFinder.new.execute(project, user, params) notes = NotesFinder.new.execute(project, user, params)
notes.size.should eq(2) notes.size.should eq(2)
end end
it 'should raise an exception for an invalid target_type' do it 'should raise an exception for an invalid target_type' do
params = { target_id: commit.id, target_type: 'invalid' } params.merge!(target_type: 'invalid')
expect { NotesFinder.new.execute(project, user, params) }.to raise_error('invalid target_type') expect { NotesFinder.new.execute(project, user, params) }.to raise_error('invalid target_type')
end end
it 'filters out old notes' do it 'filters out old notes' do
note2.update_attribute(:updated_at, 2.hours.ago) note2.update_attribute(:updated_at, 2.hours.ago)
params = { target_id: commit.id, target_type: 'commit', last_fetched_at: 1.hour.ago }
notes = NotesFinder.new.execute(project, user, params) notes = NotesFinder.new.execute(project, user, params)
notes.should eq([note1]) notes.should eq([note1])
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment