Fixed PropertyManager/PropertySheets so that you can add a property named

'ids' without the sky falling.

doc/CHANGES.txt

@@ -56,6 +56,9 @@ Zope Changes
         
     Bugs:
     
+      - Fixed PropertyManager/PropertySheets so that you can safely add a
+        property named 'ids' without breaking your properties page.
+
       - Removed spurious 'self' from scarecrow interfaces;  updated
         method-generation in Interface package to ignore self when
         source is a method (rather than a function).

lib/python/OFS/PropertyManager.py

@@ -12,7 +12,7 @@
 ##############################################################################
 
 """Property management"""
-__version__='$Revision: 1.43 $'[11:-2]
+__version__='$Revision: 1.44 $'[11:-2]
 
 import ExtensionClass, Globals
 import ZDOM
@@ -310,6 +310,10 @@ class PropertyManager(ExtensionClass.Base, ZDOM.ElementWithAttributes):
 
     def manage_delProperties(self, ids=None, REQUEST=None):
         """Delete one or more properties specified by 'ids'."""
+        if REQUEST:
+            # Bugfix for property named "ids" (Casey)
+            if ids == self.getProperty('ids', None): ids = None
+            ids = REQUEST.get('_ids', ids)
         if ids is None:
             return MessageDialog(
                    title='No property specified',

lib/python/OFS/PropertySheets.py

@@ -12,7 +12,7 @@
 ##############################################################################
 
 """Property sheets"""
-__version__='$Revision: 1.82 $'[11:-2]
+__version__='$Revision: 1.83 $'[11:-2]
 
 import time,  App.Management, Globals
 from webdav.WriteLockInterface import WriteLockInterface
@@ -421,6 +421,10 @@ class PropertySheet(Traversable, Persistent, Implicit):
 
     def manage_delProperties(self, ids=None, REQUEST=None):
         """Delete one or more properties specified by 'ids'."""
+        if REQUEST:
+            # Bugfix for properties named "ids" (casey)
+            if ids == self.getProperty('ids', None): ids = None
+            ids = REQUEST.get('_ids', ids)
         if ids is None:
             return MessageDialog(
                    title='No property specified',

lib/python/OFS/dtml/properties.dtml

@@ -42,7 +42,7 @@ property values, edit the values and click "Save Changes".
 <tr>
   <td align="left" valign="top" width="16">
   <dtml-if "'d' in _['sequence-item'].get('mode', 'awd')">
-  <input type="checkbox" name="ids:list" value="<dtml-var id html_quote>" 
+  <input type="checkbox" name="_ids:list" value="<dtml-var id html_quote>" 
    id="cb-<dtml-var id>">
   <dtml-else>
   </dtml-if>