Commit b3110a25 authored by Stefan Behnel's avatar Stefan Behnel

rewrite of the tuple unpacking code

according to unladen swallows' bm_unpack_sequence benchmark:
- ~25% faster for tuples (60% faster than CPython 2.7)
- ~3x faster for lists (40% faster than CPython 2.7)
also, apparently using less memory during gcc compilation

--HG--
extra : rebase_source : 1069d7a0c9c338c16e96cc289114e0d0052a7588
parent 183738eb
...@@ -3984,6 +3984,7 @@ class SequenceNode(ExprNode): ...@@ -3984,6 +3984,7 @@ class SequenceNode(ExprNode):
def analyse_target_types(self, env): def analyse_target_types(self, env):
self.unpacked_items = [] self.unpacked_items = []
self.coerced_unpacked_items = [] self.coerced_unpacked_items = []
self.any_coerced_items = False
for arg in self.args: for arg in self.args:
arg.analyse_target_types(env) arg.analyse_target_types(env)
if arg.is_starred: if arg.is_starred:
...@@ -3994,6 +3995,8 @@ class SequenceNode(ExprNode): ...@@ -3994,6 +3995,8 @@ class SequenceNode(ExprNode):
arg.type = Builtin.list_type arg.type = Builtin.list_type
unpacked_item = PyTempNode(self.pos, env) unpacked_item = PyTempNode(self.pos, env)
coerced_unpacked_item = unpacked_item.coerce_to(arg.type, env) coerced_unpacked_item = unpacked_item.coerce_to(arg.type, env)
if unpacked_item is not coerced_unpacked_item:
self.any_coerced_items = True
self.unpacked_items.append(unpacked_item) self.unpacked_items.append(unpacked_item)
self.coerced_unpacked_items.append(coerced_unpacked_item) self.coerced_unpacked_items.append(coerced_unpacked_item)
self.type = py_object_type self.type = py_object_type
...@@ -4020,36 +4023,67 @@ class SequenceNode(ExprNode): ...@@ -4020,36 +4023,67 @@ class SequenceNode(ExprNode):
# Need to work around the fact that generate_evaluation_code # Need to work around the fact that generate_evaluation_code
# allocates the temps in a rather hacky way -- the assignment # allocates the temps in a rather hacky way -- the assignment
# is evaluated twice, within each if-block. # is evaluated twice, within each if-block.
code.putln( special_unpack = (rhs.type is py_object_type
"if (PyTuple_CheckExact(%s) && likely(PyTuple_GET_SIZE(%s) == %s)) {" % ( or rhs.type in (tuple_type, list_type)
rhs.py_result(), or not rhs.type.is_builtin_type)
rhs.py_result(), if special_unpack:
len(self.args))) tuple_check = 'likely(PyTuple_CheckExact(%s))' % rhs.py_result()
code.putln("PyObject* tuple = %s;" % rhs.py_result()) list_check = 'PyList_CheckExact(%s)' % rhs.py_result()
if rhs.type is list_type:
sequence_types = ['List']
sequence_type_test = list_check
elif rhs.type is tuple_type:
sequence_types = ['Tuple']
sequence_type_test = tuple_check
else:
sequence_types = ['Tuple', 'List']
sequence_type_test = "(%s) || (%s)" % (tuple_check, list_check)
code.putln("if (%s) {" % sequence_type_test)
code.putln("PyObject* sequence = %s;" % rhs.py_result())
for item in self.unpacked_items: for item in self.unpacked_items:
item.allocate(code) item.allocate(code)
for i in range(len(self.args)): if len(sequence_types) == 2:
item = self.unpacked_items[i] code.putln("if (likely(Py%s_CheckExact(sequence))) {" % sequence_types[0])
code.put( self.generate_special_parallel_unpacking_code(code, sequence_types[0])
"%s = PyTuple_GET_ITEM(tuple, %d); " % ( if len(sequence_types) == 2:
item.result(), i)) code.putln("} else {")
self.generate_special_parallel_unpacking_code(code, sequence_types[1])
code.putln("}")
for item in self.unpacked_items:
code.put_incref(item.result(), item.ctype()) code.put_incref(item.result(), item.ctype())
value_node = self.coerced_unpacked_items[i]
value_node.generate_evaluation_code(code)
rhs.generate_disposal_code(code) rhs.generate_disposal_code(code)
for i in range(len(self.args)):
self.args[i].generate_assignment_code(
self.coerced_unpacked_items[i], code)
code.putln("} else {") code.putln("} else {")
if rhs.type is tuple_type: if special_unpack and rhs.type is tuple_type:
code.globalstate.use_utility_code(tuple_unpacking_error_code) code.globalstate.use_utility_code(tuple_unpacking_error_code)
code.putln("__Pyx_UnpackTupleError(%s, %s);" % ( code.putln("__Pyx_UnpackTupleError(%s, %s);" % (
rhs.py_result(), len(self.args))) rhs.py_result(), len(self.args)))
code.putln(code.error_goto(self.pos)) code.putln(code.error_goto(self.pos))
else: else:
self.generate_generic_parallel_unpacking_code(code, rhs)
if special_unpack:
code.putln("}")
for value_node in self.coerced_unpacked_items:
value_node.generate_evaluation_code(code)
for i in range(len(self.args)):
self.args[i].generate_assignment_code(
self.coerced_unpacked_items[i], code)
def generate_special_parallel_unpacking_code(self, code, sequence_type):
code.globalstate.use_utility_code(raise_need_more_values_to_unpack)
code.globalstate.use_utility_code(raise_too_many_values_to_unpack)
code.putln("if (unlikely(Py%s_GET_SIZE(sequence) != %d)) {" % (
sequence_type, len(self.args)))
code.putln("if (Py%s_GET_SIZE(sequence) > %d) __Pyx_RaiseTooManyValuesError(%d);" % (
sequence_type, len(self.args), len(self.args)))
code.putln("else __Pyx_RaiseNeedMoreValuesError(Py%s_GET_SIZE(sequence));" % sequence_type)
code.putln(code.error_goto(self.pos))
code.putln("}")
for i, item in enumerate(self.unpacked_items):
code.putln("%s = Py%s_GET_ITEM(sequence, %d); " % (item.result(), sequence_type, i))
def generate_generic_parallel_unpacking_code(self, code, rhs):
code.globalstate.use_utility_code(iternext_unpacking_end_utility_code) code.globalstate.use_utility_code(iternext_unpacking_end_utility_code)
code.globalstate.use_utility_code(raise_need_more_values_to_unpack) code.globalstate.use_utility_code(raise_need_more_values_to_unpack)
code.putln("Py_ssize_t index = -1;") code.putln("Py_ssize_t index = -1;")
...@@ -4080,8 +4114,6 @@ class SequenceNode(ExprNode): ...@@ -4080,8 +4114,6 @@ class SequenceNode(ExprNode):
item.result(), item.result(),
unpacking_error_label)) unpacking_error_label))
code.put_gotref(item.py_result()) code.put_gotref(item.py_result())
value_node = self.coerced_unpacked_items[i]
value_node.generate_evaluation_code(code)
code.put_error_if_neg(self.pos, "__Pyx_IternextUnpackEndCheck(%s(%s), %d)" % ( code.put_error_if_neg(self.pos, "__Pyx_IternextUnpackEndCheck(%s(%s), %d)" % (
iternext_func, iternext_func,
iterator_temp, iterator_temp,
...@@ -4097,15 +4129,8 @@ class SequenceNode(ExprNode): ...@@ -4097,15 +4129,8 @@ class SequenceNode(ExprNode):
code.putln("if (PyErr_Occurred() && PyErr_ExceptionMatches(PyExc_StopIteration)) PyErr_Clear();") code.putln("if (PyErr_Occurred() && PyErr_ExceptionMatches(PyExc_StopIteration)) PyErr_Clear();")
code.putln("if (!PyErr_Occurred()) __Pyx_RaiseNeedMoreValuesError(index);") code.putln("if (!PyErr_Occurred()) __Pyx_RaiseNeedMoreValuesError(index);")
code.putln(code.error_goto(self.pos)) code.putln(code.error_goto(self.pos))
code.put_label(unpacking_done_label) code.put_label(unpacking_done_label)
for i in range(len(self.args)):
self.args[i].generate_assignment_code(
self.coerced_unpacked_items[i], code)
code.putln("}")
def generate_starred_assignment_code(self, rhs, code): def generate_starred_assignment_code(self, rhs, code):
for i, arg in enumerate(self.args): for i, arg in enumerate(self.args):
if arg.is_starred: if arg.is_starred:
......
...@@ -7,9 +7,21 @@ def _it(N): ...@@ -7,9 +7,21 @@ def _it(N):
for i in range(N): for i in range(N):
yield i yield i
def f(obj1, obj2, obj3, obj4, obj5): cdef class ItCount(object):
cdef object values
cdef readonly count
def __init__(self, values):
self.values = iter(values)
self.count = 0
def __iter__(self):
return self
def __next__(self):
self.count += 1
return next(self.values)
def kunterbunt(obj1, obj2, obj3, obj4, obj5):
""" """
>>> f(1, (2,), (3,4,5), (6,(7,(8,9))), 0) >>> kunterbunt(1, (2,), (3,4,5), (6,(7,(8,9))), 0)
(8, 9, (8, 9), (6, (7, (8, 9))), 0) (8, 9, (8, 9), (6, (7, (8, 9))), 0)
""" """
obj1, = obj2 obj1, = obj2
...@@ -19,16 +31,177 @@ def f(obj1, obj2, obj3, obj4, obj5): ...@@ -19,16 +31,177 @@ def f(obj1, obj2, obj3, obj4, obj5):
[obj1, obj2] = obj3 [obj1, obj2] = obj3
return obj1, obj2, obj3, obj4, obj5 return obj1, obj2, obj3, obj4, obj5
def unpack_tuple(tuple it):
"""
>>> unpack_tuple((1,2,3))
(1, 2, 3)
>>> a,b,c = None
Traceback (most recent call last):
TypeError: 'NoneType' object is not iterable
>>> unpack_tuple(None)
Traceback (most recent call last):
TypeError: 'NoneType' object is not iterable
"""
a,b,c = it
return a,b,c
def unpack_list(list it):
"""
>>> unpack_list([1,2,3])
(1, 2, 3)
>>> a,b,c = None
Traceback (most recent call last):
TypeError: 'NoneType' object is not iterable
>>> unpack_list(None)
Traceback (most recent call last):
TypeError: 'NoneType' object is not iterable
"""
a,b,c = it
return a,b,c
def unpack_to_itself(it):
"""
>>> it = _it(2)
>>> it, it = it
>>> it
1
>>> unpack_to_itself([1,2])
2
>>> unpack_to_itself((1,2))
2
>>> unpack_to_itself(_it(2))
1
>>> unpack_to_itself((1,2,3))
Traceback (most recent call last):
ValueError: too many values to unpack (expected 2)
>>> unpack_to_itself(_it(3))
Traceback (most recent call last):
ValueError: too many values to unpack (expected 2)
"""
it, it = it
return it
def unpack_partial(it):
"""
>>> it = _it(2)
>>> a = b = c = 0
>>> a,b,c = it
Traceback (most recent call last):
ValueError: need more than 2 values to unpack
>>> a, b, c
(0, 0, 0)
>>> unpack_partial([1,2])
(0, 0, 0)
>>> unpack_partial((1,2))
(0, 0, 0)
>>> unpack_partial(_it(2))
(0, 0, 0)
>>> it = ItCount([1,2])
>>> a = b = c = 0
>>> a,b,c = it
Traceback (most recent call last):
ValueError: need more than 2 values to unpack
>>> a, b, c
(0, 0, 0)
>>> it.count
3
>>> it = ItCount([1,2])
>>> unpack_partial(it)
(0, 0, 0)
>>> it.count
3
"""
a = b = c = 0
try:
a, b, c = it
except ValueError:
pass
return a, b, c
def unpack_fail_assignment(it):
"""
>>> it = ItCount([1, 2, 3])
>>> a = b = c = 0
>>> try: a, b[0], c = it
... except TypeError: pass
>>> a,b,c
(1, 0, 0)
>>> it.count
4
>>> it = ItCount([1, 2, 3])
>>> unpack_fail_assignment(it)
(1, 0, 0)
>>> it.count
4
"""
cdef object a,b,c
a = b = c = 0
try:
a, b[0], c = it
except TypeError:
pass
return a, b, c
def unpack_partial_typed(it):
"""
>>> unpack_partial_typed([1, 2, 'abc'])
(0, 0, 0)
>>> unpack_partial_typed((1, 'abc', 3))
(0, 0, 0)
>>> unpack_partial_typed(_set([1, 'abc', 3]))
(0, 0, 0)
>>> it = ItCount([1, 'abc', 3])
>>> unpack_partial_typed(it)
(0, 0, 0)
>>> it.count
4
"""
cdef int a,b,c
a = b = c = 0
try:
a, b, c = it
except TypeError:
pass
return a, b, c
def unpack_typed(it): def unpack_typed(it):
""" """
>>> unpack_typed((1, 2.0, [1])) >>> unpack_typed((1, 2.0, [1]))
(1, 2.0, [1]) (1, 2.0, [1])
>>> unpack_typed([1, 2.0, [1]])
(1, 2.0, [1])
>>> it = ItCount([1, 2.0, [1]])
>>> unpack_typed(it)
(1, 2.0, [1])
>>> it.count
4
>>> unpack_typed((1, None, [1])) >>> unpack_typed((1, None, [1]))
Traceback (most recent call last): Traceback (most recent call last):
TypeError: a float is required TypeError: a float is required
>>> unpack_typed([1, None, [1]])
Traceback (most recent call last):
TypeError: a float is required
>>> it = ItCount([1, None, [1]])
>>> unpack_typed(it)
Traceback (most recent call last):
TypeError: a float is required
>>> it.count
4
>>> unpack_typed((1, 2.0, (1,))) >>> unpack_typed((1, 2.0, (1,)))
Traceback (most recent call last): Traceback (most recent call last):
TypeError: Expected list, got tuple TypeError: Expected list, got tuple
>>> it = ItCount([1, 2.0, (1,)])
>>> unpack_typed(it)
Traceback (most recent call last):
TypeError: Expected list, got tuple
>>> it.count
4
""" """
cdef int a cdef int a
cdef float b cdef float b
...@@ -67,6 +240,7 @@ def failure_too_many(it): ...@@ -67,6 +240,7 @@ def failure_too_many(it):
ValueError: too many values to unpack (expected 3) ValueError: too many values to unpack (expected 3)
""" """
a,b,c = it a,b,c = it
return a,b,c
def failure_too_few(it): def failure_too_few(it):
""" """
...@@ -99,6 +273,7 @@ def failure_too_few(it): ...@@ -99,6 +273,7 @@ def failure_too_few(it):
ValueError: need more than 2 values to unpack ValueError: need more than 2 values to unpack
""" """
a,b,c = it a,b,c = it
return a,b,c
def _it_failure(N): def _it_failure(N):
for i in range(N): for i in range(N):
...@@ -143,3 +318,4 @@ def failure_while_unpacking(it): ...@@ -143,3 +318,4 @@ def failure_while_unpacking(it):
ValueError: too many values to unpack (expected 3) ValueError: too many values to unpack (expected 3)
""" """
a,b,c = it a,b,c = it
return a,b,c
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment