Commit 276b3a7b authored by Douwe Maan's avatar Douwe Maan

Make Mentionable#cross_reference_exists? private.

parent 530f0d71
...@@ -41,12 +41,6 @@ module Mentionable ...@@ -41,12 +41,6 @@ module Mentionable
self self
end end
# Determine whether or not a cross-reference Note has already been created between this Mentionable and
# the specified target.
def cross_reference_exists?(target)
SystemNoteService.cross_reference_exists?(target, local_reference)
end
def all_references(current_user = self.author, text = self.mentionable_text) def all_references(current_user = self.author, text = self.mentionable_text)
ext = Gitlab::ReferenceExtractor.new(self.project, current_user) ext = Gitlab::ReferenceExtractor.new(self.project, current_user)
ext.analyze(text) ext.analyze(text)
...@@ -111,4 +105,10 @@ module Mentionable ...@@ -111,4 +105,10 @@ module Mentionable
# Only include changed fields that are mentionable # Only include changed fields that are mentionable
source.select { |key, val| mentionable.include?(key) } source.select { |key, val| mentionable.include?(key) }
end end
# Determine whether or not a cross-reference Note has already been created between this Mentionable and
# the specified target.
def cross_reference_exists?(target)
SystemNoteService.cross_reference_exists?(target, local_reference)
end
end end
...@@ -86,13 +86,6 @@ shared_examples 'a mentionable' do ...@@ -86,13 +86,6 @@ shared_examples 'a mentionable' do
subject.create_cross_references! subject.create_cross_references!
end end
it 'detects existing cross-references' do
SystemNoteService.cross_reference(mentioned_issue, subject.local_reference, author)
expect(subject.cross_reference_exists?(mentioned_issue)).to be_truthy
expect(subject.cross_reference_exists?(mentioned_mr)).to be_falsey
end
end end
shared_examples 'an editable mentionable' do shared_examples 'an editable mentionable' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment