Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
gitlab-ce
Commits
568ce1ed
Commit
568ce1ed
authored
Apr 04, 2013
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix notes for commits inside MR being squashed in one discussion
parent
64fb2c59
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
3 deletions
+2
-3
app/controllers/notes_controller.rb
app/controllers/notes_controller.rb
+1
-2
app/models/note.rb
app/models/note.rb
+1
-1
No files found.
app/controllers/notes_controller.rb
View file @
568ce1ed
...
@@ -71,7 +71,6 @@ class NotesController < ProjectResourceController
...
@@ -71,7 +71,6 @@ class NotesController < ProjectResourceController
# Helps to distinguish e.g. commit notes in mr notes list
# Helps to distinguish e.g. commit notes in mr notes list
def
note_for_main_target?
(
note
)
def
note_for_main_target?
(
note
)
note
.
for_wall?
||
(
@target_type
.
camelize
==
note
.
noteable_type
&&
!
note
.
for_diff_line?
)
(
@target_type
.
camelize
==
note
.
noteable_type
&&
!
note
.
for_diff_line?
)
end
end
end
end
app/models/note.rb
View file @
568ce1ed
...
@@ -88,7 +88,7 @@ class Note < ActiveRecord::Base
...
@@ -88,7 +88,7 @@ class Note < ActiveRecord::Base
end
end
def
discussion_id
def
discussion_id
@discussion_id
||=
[
:discussion
,
noteable_type
.
try
(
:underscore
),
noteable_id
,
line_code
].
join
(
"-"
).
to_sym
@discussion_id
||=
[
:discussion
,
noteable_type
.
try
(
:underscore
),
noteable_id
||
commit_id
,
line_code
].
join
(
"-"
).
to_sym
end
end
# Returns true if this is a downvote note,
# Returns true if this is a downvote note,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment