Merge branch 'stop_popen_zombies'

Conflicts:
	CHANGELOG

CHANGELOG

@@ -21,7 +21,7 @@ v 7.8.0
   - 
   - 
   - Upgrade Sidekiq gem to version 3.3.0
-  - 
+  - Stop git zombie creation during force push check
   - 
   - 
   - Fix commits pagination
@@ -1107,4 +1107,4 @@ v 0.8.0
   - stability
   - security fixes
   - increased test coverage
-  - email notification
+  - email notification
\ No newline at end of file

doc/development/shell_commands.md

@@ -108,7 +108,7 @@ In other repositories, such as gitlab-shell you can also use `IO.popen`.
 
 ```ruby
 # Safe IO.popen example
-logs = IO.popen(%W(git log), chdir: repo_dir).read
+logs = IO.popen(%W(git log), chdir: repo_dir) { |p| p.read }
 ```
 
 Note that unlike `Gitlab::Popen.popen`, `IO.popen` does not capture standard error.

lib/gitlab/force_push_check.rb

@@ -4,7 +4,7 @@ module Gitlab
       return false if project.empty_repo?
 
       if oldrev != Gitlab::Git::BLANK_SHA && newrev != Gitlab::Git::BLANK_SHA
-        missed_refs = IO.popen(%W(git --git-dir=#{project.repository.path_to_repo} rev-list #{oldrev} ^#{newrev})).read
+        missed_refs, _ = Gitlab::Popen.popen(%W(git --git-dir=#{project.repository.path_to_repo} rev-list #{oldrev} ^#{newrev}))
         missed_refs.split("\n").size > 0
       else
         false