Merge branch 'fix/gitlab-importer-issue' into 'master'

Fix gitlab importer issue

Fixed credentials not being called correctly - probably some bad refactoring or search & replace... 

Fixes https://gitlab.com/gitlab-org/gitlab-ee/issues/565

See merge request !4301

CHANGELOG

@@ -5,6 +5,9 @@ v 8.8.3
   - Fixed potential issue with 2 ci status polling events happening. !3869
   - Improve design of Pipeline View. !4230
 
+v 8.8.3
+  - Fix gitlab importer failing to import new projects due to missing credentials
+
 v 8.8.2
   - Added remove due date button. !4209
   - Fix Error 500 when accessing application settings due to nil disabled OAuth sign-in sources. !4242

lib/gitlab/gitlab_import/importer.rb

@@ -5,9 +5,9 @@ module Gitlab
 
       def initialize(project)
         @project = project
-        credentials = project.import_data
-        if credentials && credentials[:password]
-          @client = Client.new(credentials[:password])
+        import_data = project.import_data
+        if import_data && import_data.credentials && import_data.credentials[:password]
+          @client = Client.new(import_data.credentials[:password])
           @formatter = Gitlab::ImportFormatter.new
         else
           raise Projects::ImportService::Error, "Unable to find project import data credentials for project ID: #{@project.id}"