Migrate issue/mr labels from act_as_taggable to own labels

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

app/finders/base_finder.rb

@@ -125,7 +125,7 @@ class BaseFinder
 
   def by_label(items)
     if params[:label_name].present?
-      items = items.tagged_with(params[:label_name])
+      items = items.joins(:labels).where("labels.title = ?", params[:label_name])
     end
 
     items

app/helpers/labels_helper.rb

 module LabelsHelper
   def issue_label_names
-    @project.issues_labels.map(&:name)
+    @project.labels.pluck(:title)
   end
 
   def labels_autocomplete_source
-    labels = @project.issues_labels
-    labels = labels.map{ |l| { label: l.name, value: l.name } }
+    labels = @project.labels
+    labels = labels.map { |l| { label: l.name, value: l.name } }
     labels.to_json
   end
 

app/models/concerns/issuable.rb

@@ -13,6 +13,8 @@ module Issuable
     belongs_to :assignee, class_name: "User"
     belongs_to :milestone
     has_many :notes, as: :noteable, dependent: :destroy
+    has_many :label_links, as: :target, dependent: :destroy
+    has_many :labels, through: :label_links
 
     validates :author, presence: true
     validates :title, presence: true, length: { within: 0..255 }

app/models/issue.rb

@@ -32,9 +32,6 @@ class Issue < ActiveRecord::Base
 
   scope :of_group, ->(group) { where(project_id: group.project_ids) }
   scope :of_user_team, ->(team) { where(project_id: team.project_ids, assignee_id: team.member_ids) }
-
-  acts_as_taggable_on :labels
-
   scope :cared, ->(user) { where(assignee_id: user) }
   scope :open_for, ->(user) { opened.assigned_to(user) }
 

app/models/label.rb

@@ -4,4 +4,9 @@ class Label < ActiveRecord::Base
 
   validates :color, format: { with: /\A\#[0-9A-Fa-f]{3}{1,2}+\Z/ }, allow_blank: true
   validates :project, presence: true
+  validates :title, presence: true
+
+  def name
+    title
+  end
 end

app/models/merge_request.rb

@@ -47,9 +47,6 @@ class MergeRequest < ActiveRecord::Base
   attr_accessor :can_be_created, :compare_failed,
     :compare_commits, :compare_diffs
 
-  ActsAsTaggableOn.strict_case_match = true
-  acts_as_taggable_on :labels
-
   state_machine :state, initial: :opened do
     event :close do
       transition [:reopened, :opened] => :closed

app/models/project.rb

@@ -41,8 +41,7 @@ class Project < ActiveRecord::Base
   default_value_for :snippets_enabled, gitlab_config_features.snippets
 
   ActsAsTaggableOn.strict_case_match = true
-
-  acts_as_taggable_on :tags, :issues_default_labels
+  acts_as_taggable_on :tags
 
   attr_accessor :new_default_branch
 
@@ -71,6 +70,7 @@ class Project < ActiveRecord::Base
   # Merge requests from source project should be kept when source project was removed
   has_many :fork_merge_requests, foreign_key: "source_project_id", class_name: MergeRequest
   has_many :issues, -> { order "state DESC, created_at DESC" }, dependent: :destroy
+  has_many :labels,             dependent: :destroy
   has_many :services,           dependent: :destroy
   has_many :events,             dependent: :destroy
   has_many :milestones,         dependent: :destroy
@@ -282,13 +282,6 @@ class Project < ActiveRecord::Base
     self.id
   end
 
-  # Tags are shared by issues and merge requests
-  def issues_labels
-    @issues_labels ||= (issues_default_labels +
-                        merge_requests.tags_on(:labels) +
-                        issues.tags_on(:labels)).uniq.sort_by(&:name)
-  end
-
   def issue_exists?(issue_id)
     if used_default_issues_tracker?
       self.issues.where(iid: issue_id).first.present?

db/migrate/20140729152420_migrate_taggable_labels.rb

+class MigrateTaggableLabels < ActiveRecord::Migration
+  def up
+    taggings = ActsAsTaggableOn::Tagging.where(taggable_type: ['Issue', 'MergeRequest'], context: 'labels')
+    taggings.find_each(batch_size: 500) do |tagging|
+      create_label_from_tagging(tagging)
+    end
+  end
+
+  def down
+    Label.destroy_all
+    LabelLink.destroy_all
+  end
+
+  private
+
+  def create_label_from_tagging(tagging)
+    target = tagging.taggable
+    label_name = tagging.tag.name
+    label = target.project.labels.find_or_create_by(title: label_name)
+
+    if LabelLink.create(label: label, target: target)
+      print '.'
+    else
+      print 'F'
+    end
+  end
+end

db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20140729145339) do
+ActiveRecord::Schema.define(version: 20140729152420) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"

lib/gitlab/issues_labels.rb

@@ -18,10 +18,11 @@ module Gitlab
       end
 
       def generate(project)
-        labels = important_labels + warning_labels + neutral_labels + positive_labels
+        label_names = important_labels + warning_labels + neutral_labels + positive_labels
 
-        project.issues_default_label_list = labels
-        project.save
+        label_names.each do |label_name|
+          project.labels.create(title: label_name)
+        end
       end
     end
   end