Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
gitlab-ce
Commits
d54a281e
Commit
d54a281e
authored
Jul 12, 2016
by
Douglas Barbosa Alexandre
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix creating group with space in group path
parent
c49517a0
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
5 deletions
+17
-5
app/views/layouts/_search.html.haml
app/views/layouts/_search.html.haml
+1
-1
spec/features/groups_spec.rb
spec/features/groups_spec.rb
+16
-4
No files found.
app/views/layouts/_search.html.haml
View file @
d54a281e
...
@@ -44,7 +44,7 @@
...
@@ -44,7 +44,7 @@
name
:
"
#{
j
(
@project
.
name
)
}
"
name
:
"
#{
j
(
@project
.
name
)
}
"
};
};
-
if
@group
and
@group
.
path
-
if
@group
&&
@group
.
persisted?
&&
@group
.
path
:javascript
:javascript
gl
.
groupOptions
=
gl
.
groupOptions
||
{};
gl
.
groupOptions
=
gl
.
groupOptions
||
{};
gl
.
groupOptions
[
"
#{
j
(
@group
.
path
)
}
"
]
=
{
gl
.
groupOptions
[
"
#{
j
(
@group
.
path
)
}
"
]
=
{
...
...
spec/features/groups_spec.rb
View file @
d54a281e
require
'spec_helper'
require
'spec_helper'
feature
'Group'
,
feature:
true
do
feature
'Group'
,
feature:
true
do
describe
'description'
do
let
(
:group
)
{
create
(
:group
)
}
let
(
:path
)
{
group_path
(
group
)
}
before
do
before
do
login_as
(
:admin
)
login_as
(
:admin
)
end
end
describe
'creating a group with space in group path'
do
it
'renders new group form with validation errors'
do
visit
new_group_path
fill_in
'Group path'
,
with:
'space group'
click_button
'Create group'
expect
(
current_path
).
to
eq
(
groups_path
)
expect
(
page
).
to
have_content
(
"Path can contain only letters, digits, '_', '-' and '.'. Cannot start with '-' or end in '.'."
)
end
end
describe
'description'
do
let
(
:group
)
{
create
(
:group
)
}
let
(
:path
)
{
group_path
(
group
)
}
it
'parses Markdown'
do
it
'parses Markdown'
do
group
.
update_attribute
(
:description
,
'This is **my** group'
)
group
.
update_attribute
(
:description
,
'This is **my** group'
)
visit
path
visit
path
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment