1. 15 Apr, 2015 2 commits
  2. 14 Apr, 2015 32 commits
  3. 13 Apr, 2015 6 commits
    • Hannes Rosenögger's avatar
      Merge branch 'fix_tests_help_link_2' into 'master' · a1e147ce
      Hannes Rosenögger authored
      fix failing test
      
      This should fix:
      
      ```
      Coverage report generated for RSpec to /home/gitlab-runner/tmp/builds/project-1/coverage. 4331 / 8315 LOC (52.09%) covered.
      /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/racc-1.4.10/lib/racc/parser.rb:532:in `on_error':  (Racc::ParseError)
      parse error on value "Background" (BACKGROUND)
      	from /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/racc-1.4.10/lib/racc/parser.rb:264:in `_racc_do_parse_c'
      	from /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/racc-1.4.10/lib/racc/parser.rb:264:in `do_parse'
      	from /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/gherkin-ruby-0.3.1/lib/gherkin_ruby/parser/lexer.rb:31:in `scan_str'
      	from gherkin.y:107:in `parse'
      	from /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/gherkin-ruby-0.3.1/lib/gherkin_ruby.rb:8:in `parse'
      	from /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/spinach-0.8.7/lib/spinach/parser.rb:39:in `parse'
      	from /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/spinach-0.8.7/lib/spinach/runner.rb:75:in `block in run'
      	from /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/spinach-0.8.7/lib/spinach/runner.rb:74:in `each'
      	from /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/spinach-0.8.7/lib/spinach/runner.rb:74:in `run'
      	from /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/spinach-0.8.7/lib/spinach/cli.rb:27:in `run'
      	from /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/spinach-0.8.7/bin/spinach:15:in `<top (required)>'
      	from /home/gitlab-runner/bin/spinach:23:in `load'
      	from /home/gitlab-runner/bin/spinach:23:in `<main>'
      rake aborted!
      ```
      
      Seems that I deleted a bit to much with my last attempt to remove the failing test.
      I've run the entire spinach suite again locally and it seems to pass.
      
      See merge request !516
      a1e147ce
    • Hannes Rosenögger's avatar
      fix failing test · a62dbd11
      Hannes Rosenögger authored
      a62dbd11
    • Douwe Maan's avatar
      Merge branch 'fix_tests_help_link' into 'master' · f124aceb
      Douwe Maan authored
      Remove failing test
      
      Earlier today I accepted a MR that removed the redundant help link on the dashboard sidebar.
      This MR removes the now failing test.
      
      See merge request !515
      f124aceb
    • Hannes Rosenögger's avatar
    • Hannes Rosenögger's avatar
      Merge branch 'empty-avatar-alt-text' into 'master' · 63f0f6f3
      Hannes Rosenögger authored
      Explicitly set image alt to prevent graphical glitches
      
      Rails image_tag sets the alt-attribute to the filename which causes graphical glitches if the file could not be loaded.
      
      Fixes https://github.com/gitlabhq/gitlabhq/issues/6036.
      Signed-off-by: default avatarSven Strickroth <email@cs-ware.de>
      
      See merge request !503
      63f0f6f3
    • Sven Strickroth's avatar
      Explicitly set image alt to prevent graphical glitches · 57c2a9f0
      Sven Strickroth authored
      Rails image_tag sets the alt-attribute to the filename which causes graphical glitches if the file could not be loaded.
      
      Fixes https://github.com/gitlabhq/gitlabhq/issues/6036.
      Signed-off-by: default avatarSven Strickroth <email@cs-ware.de>
      57c2a9f0