• Lubomir I. Ivanov (VMware)'s avatar
    path/filepath: fix Win32 tests missing 'chcp' · 0d54fb56
    Lubomir I. Ivanov (VMware) authored
    '%SystemRoot%/System32/chcp.com' is a tool on Windows that
    is used to change the active code page in the console.
    
    'go test path/filepath' can fail with:
    "'chcp' is not recognized as an internal or external command"
    
    The test uses a custom PATH variable but does not include
    '%SystemRoot%/System32'. Always append that to PATH.
    
    Updates #24709
    
    Change-Id: Ib4c83ffdcc5dd6eb7bb34c07386cf2ab61dcae57
    GitHub-Last-Rev: fac92613cce0d60f6794ad850618ed64d04c76fd
    GitHub-Pull-Request: golang/go#25089
    Reviewed-on: https://go-review.googlesource.com/109362
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
    0d54fb56
path_windows_test.go 15.2 KB