Commit 1e4a3584 authored by Constantin Konstantinidis's avatar Constantin Konstantinidis Committed by Brad Fitzpatrick

net/http: deflake TestCancelRequestWithChannelBeforeDo_Cancel

Goroutines clean up takes longer when using deprecated CloseNotifier.

Fixes #35122

Change-Id: Id820a3012b5c781ddfb294b38ee3b009624e398c
Reviewed-on: https://go-review.googlesource.com/c/go/+/204661
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
parent dc39be8b
...@@ -122,7 +122,7 @@ func afterTest(t testing.TB) { ...@@ -122,7 +122,7 @@ func afterTest(t testing.TB) {
").noteClientGone(": "a closenotifier sender", ").noteClientGone(": "a closenotifier sender",
} }
var stacks string var stacks string
for i := 0; i < 4; i++ { for i := 0; i < 10; i++ {
bad = "" bad = ""
stacks = strings.Join(interestingGoroutines(), "\n\n") stacks = strings.Join(interestingGoroutines(), "\n\n")
for substr, what := range badSubstring { for substr, what := range badSubstring {
......
...@@ -22,7 +22,6 @@ import ( ...@@ -22,7 +22,6 @@ import (
"fmt" "fmt"
"go/token" "go/token"
"internal/nettrace" "internal/nettrace"
"internal/testenv"
"io" "io"
"io/ioutil" "io/ioutil"
"log" "log"
...@@ -2355,9 +2354,6 @@ func TestCancelRequestWithChannel(t *testing.T) { ...@@ -2355,9 +2354,6 @@ func TestCancelRequestWithChannel(t *testing.T) {
} }
func TestCancelRequestWithChannelBeforeDo_Cancel(t *testing.T) { func TestCancelRequestWithChannelBeforeDo_Cancel(t *testing.T) {
if os.Getenv("GO_BUILDER_NAME") == "windows-amd64-longtest" {
testenv.SkipFlaky(t, 35122)
}
testCancelRequestWithChannelBeforeDo(t, false) testCancelRequestWithChannelBeforeDo(t, false)
} }
func TestCancelRequestWithChannelBeforeDo_Context(t *testing.T) { func TestCancelRequestWithChannelBeforeDo_Context(t *testing.T) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment