Commit 2b8cbc38 authored by Brad Fitzpatrick's avatar Brad Fitzpatrick

syscall: don't return EINVAL on zero Chmod mode on Windows

Fixes #20858

Change-Id: I45c397795426aaa276b20f5cbeb80270c95b920c
Reviewed-on: https://go-review.googlesource.com/c/go/+/174320Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
parent 6ee83243
...@@ -490,11 +490,11 @@ func UserHomeDir() (string, error) { ...@@ -490,11 +490,11 @@ func UserHomeDir() (string, error) {
// On Unix, the mode's permission bits, ModeSetuid, ModeSetgid, and // On Unix, the mode's permission bits, ModeSetuid, ModeSetgid, and
// ModeSticky are used. // ModeSticky are used.
// //
// On Windows, the mode must be non-zero but otherwise only the 0200 // On Windows, only the 0200 bit (owner writable) of mode is used; it
// bit (owner writable) of mode is used; it controls whether the // controls whether the file's read-only attribute is set or cleared.
// file's read-only attribute is set or cleared. attribute. The other // The other bits are currently unused. For compatibilty with Go 1.12
// bits are currently unused. Use mode 0400 for a read-only file and // and earlier, use a non-zero mode. Use mode 0400 for a read-only
// 0600 for a readable+writable file. // file and 0600 for a readable+writable file.
// //
// On Plan 9, the mode's permission bits, ModeAppend, ModeExclusive, // On Plan 9, the mode's permission bits, ModeAppend, ModeExclusive,
// and ModeTemporary are used. // and ModeTemporary are used.
......
...@@ -567,9 +567,6 @@ func Fsync(fd Handle) (err error) { ...@@ -567,9 +567,6 @@ func Fsync(fd Handle) (err error) {
} }
func Chmod(path string, mode uint32) (err error) { func Chmod(path string, mode uint32) (err error) {
if mode == 0 {
return EINVAL
}
p, e := UTF16PtrFromString(path) p, e := UTF16PtrFromString(path)
if e != nil { if e != nil {
return e return e
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment