Commit 2ebf0de2 authored by David Symonds's avatar David Symonds

net/http: change test to use override param instead of chan.

Follow-on from https://golang.org/cl/5543062.

R=bradfitz, dvyukov
CC=golang-dev
https://golang.org/cl/5539071
parent 4985ee3d
...@@ -224,16 +224,15 @@ func TestEmptyDirOpenCWD(t *testing.T) { ...@@ -224,16 +224,15 @@ func TestEmptyDirOpenCWD(t *testing.T) {
func TestServeFileContentType(t *testing.T) { func TestServeFileContentType(t *testing.T) {
const ctype = "icecream/chocolate" const ctype = "icecream/chocolate"
override := make(chan bool, 1)
ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {
if <-override { if r.FormValue("override") == "1" {
w.Header().Set("Content-Type", ctype) w.Header().Set("Content-Type", ctype)
} }
ServeFile(w, r, "testdata/file") ServeFile(w, r, "testdata/file")
})) }))
defer ts.Close() defer ts.Close()
get := func(want string) { get := func(override, want string) {
resp, err := Get(ts.URL) resp, err := Get(ts.URL + "?override=" + override)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
...@@ -241,10 +240,8 @@ func TestServeFileContentType(t *testing.T) { ...@@ -241,10 +240,8 @@ func TestServeFileContentType(t *testing.T) {
t.Errorf("Content-Type mismatch: got %q, want %q", h, want) t.Errorf("Content-Type mismatch: got %q, want %q", h, want)
} }
} }
override <- false get("0", "text/plain; charset=utf-8")
get("text/plain; charset=utf-8") get("1", ctype)
override <- true
get(ctype)
} }
func TestServeFileMimeType(t *testing.T) { func TestServeFileMimeType(t *testing.T) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment