Commit 55282111 authored by Andrew Gerrand's avatar Andrew Gerrand

misc/dashboard/app: fix build failure notifications

The datastore.Query methods once mutated the Query value, but now they return
a derivative query, so the Hash= and ParentHash= filters were not being
applied.

R=golang-dev, bradfitz, dsymonds
CC=golang-dev
https://golang.org/cl/6300058
parent 42a76efc
...@@ -45,7 +45,7 @@ func notifyOnFailure(c appengine.Context, com *Commit, builder string) error { ...@@ -45,7 +45,7 @@ func notifyOnFailure(c appengine.Context, com *Commit, builder string) error {
if cr.OK { if cr.OK {
// This commit is OK. Notify if next Commit is broken. // This commit is OK. Notify if next Commit is broken.
next := new(Commit) next := new(Commit)
q.Filter("ParentHash=", com.Hash) q = q.Filter("ParentHash=", com.Hash)
if err := firstMatch(c, q, next); err != nil { if err := firstMatch(c, q, next); err != nil {
if err == datastore.ErrNoSuchEntity { if err == datastore.ErrNoSuchEntity {
// OK at tip, no notification necessary. // OK at tip, no notification necessary.
...@@ -61,7 +61,7 @@ func notifyOnFailure(c appengine.Context, com *Commit, builder string) error { ...@@ -61,7 +61,7 @@ func notifyOnFailure(c appengine.Context, com *Commit, builder string) error {
} else { } else {
// This commit is broken. Notify if the previous Commit is OK. // This commit is broken. Notify if the previous Commit is OK.
prev := new(Commit) prev := new(Commit)
q.Filter("Hash=", com.ParentHash) q = q.Filter("Hash=", com.ParentHash)
if err := firstMatch(c, q, prev); err != nil { if err := firstMatch(c, q, prev); err != nil {
if err == datastore.ErrNoSuchEntity { if err == datastore.ErrNoSuchEntity {
// No previous result, let the backfill of // No previous result, let the backfill of
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment