Commit 56b8ee23 authored by Bryan C. Mills's avatar Bryan C. Mills

cmd/go: retry RemoveAll(workdir) for up to 500ms

On some configurations of Windows, directories containing executable
files may be locked for a while after the executable exits (perhaps
due to antivirus scans?). It's probably worth a little extra latency
on exit to avoid filling up the user's temporary directory with leaked
files.

Updates #30789

Change-Id: Iae7fcdd07fb9ecfb05967cfe0c8833db646d2f85
Reviewed-on: https://go-review.googlesource.com/c/go/+/172337
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
parent 518ee55d
...@@ -16,8 +16,10 @@ import ( ...@@ -16,8 +16,10 @@ import (
"io/ioutil" "io/ioutil"
"os" "os"
"path/filepath" "path/filepath"
"runtime"
"strings" "strings"
"sync" "sync"
"time"
"cmd/go/internal/base" "cmd/go/internal/base"
"cmd/go/internal/cache" "cmd/go/internal/cache"
...@@ -243,8 +245,23 @@ func (b *Builder) Init() { ...@@ -243,8 +245,23 @@ func (b *Builder) Init() {
if !cfg.BuildWork { if !cfg.BuildWork {
workdir := b.WorkDir workdir := b.WorkDir
base.AtExit(func() { base.AtExit(func() {
if err := os.RemoveAll(workdir); err != nil { start := time.Now()
for {
err := os.RemoveAll(workdir)
if err == nil {
return
}
// On some configurations of Windows, directories containing executable
// files may be locked for a while after the executable exits (perhaps
// due to antivirus scans?). It's probably worth a little extra latency
// on exit to avoid filling up the user's temporary directory with leaked
// files. (See golang.org/issue/30789.)
if runtime.GOOS != "windows" || time.Since(start) >= 500*time.Millisecond {
fmt.Fprintf(os.Stderr, "go: failed to remove work dir: %s\n", err) fmt.Fprintf(os.Stderr, "go: failed to remove work dir: %s\n", err)
return
}
time.Sleep(5 * time.Millisecond)
} }
}) })
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment