Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
go
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
go
Commits
5abf4bdc
Commit
5abf4bdc
authored
Oct 19, 2012
by
Nigel Tao
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
image/draw: fast-path for 4:4:0 chroma subsampled sources.
R=r CC=golang-dev
https://golang.org/cl/6699049
parent
1e6d9f49
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
26 additions
and
8 deletions
+26
-8
src/pkg/image/draw/draw.go
src/pkg/image/draw/draw.go
+25
-8
src/pkg/image/jpeg/reader_test.go
src/pkg/image/jpeg/reader_test.go
+1
-0
src/pkg/image/testdata/video-001.q50.440.jpeg
src/pkg/image/testdata/video-001.q50.440.jpeg
+0
-0
src/pkg/image/testdata/video-001.q50.440.progressive.jpeg
src/pkg/image/testdata/video-001.q50.440.progressive.jpeg
+0
-0
No files found.
src/pkg/image/draw/draw.go
View file @
5abf4bdc
...
...
@@ -81,9 +81,10 @@ func DrawMask(dst Image, r image.Rectangle, src image.Image, sp image.Point, mas
drawNRGBAOver
(
dst0
,
r
,
src0
,
sp
)
return
case
*
image
.
YCbCr
:
drawYCbCr
(
dst0
,
r
,
src0
,
sp
)
if
drawYCbCr
(
dst0
,
r
,
src0
,
sp
)
{
return
}
}
}
else
if
mask0
,
ok
:=
mask
.
(
*
image
.
Alpha
);
ok
{
switch
src0
:=
src
.
(
type
)
{
case
*
image
.
Uniform
:
...
...
@@ -104,11 +105,12 @@ func DrawMask(dst Image, r image.Rectangle, src image.Image, sp image.Point, mas
drawNRGBASrc
(
dst0
,
r
,
src0
,
sp
)
return
case
*
image
.
YCbCr
:
drawYCbCr
(
dst0
,
r
,
src0
,
sp
)
if
drawYCbCr
(
dst0
,
r
,
src0
,
sp
)
{
return
}
}
}
}
drawRGBA
(
dst0
,
r
,
src
,
sp
,
mask
,
mp
,
op
)
return
}
...
...
@@ -345,7 +347,7 @@ func drawNRGBASrc(dst *image.RGBA, r image.Rectangle, src *image.NRGBA, sp image
}
}
func
drawYCbCr
(
dst
*
image
.
RGBA
,
r
image
.
Rectangle
,
src
*
image
.
YCbCr
,
sp
image
.
Point
)
{
func
drawYCbCr
(
dst
*
image
.
RGBA
,
r
image
.
Rectangle
,
src
*
image
.
YCbCr
,
sp
image
.
Point
)
(
ok
bool
)
{
// An image.YCbCr is always fully opaque, and so if the mask is implicitly nil
// (i.e. fully opaque) then the op is effectively always Src.
x0
:=
(
r
.
Min
.
X
-
dst
.
Rect
.
Min
.
X
)
*
4
...
...
@@ -353,6 +355,19 @@ func drawYCbCr(dst *image.RGBA, r image.Rectangle, src *image.YCbCr, sp image.Po
y0
:=
r
.
Min
.
Y
-
dst
.
Rect
.
Min
.
Y
y1
:=
r
.
Max
.
Y
-
dst
.
Rect
.
Min
.
Y
switch
src
.
SubsampleRatio
{
case
image
.
YCbCrSubsampleRatio444
:
for
y
,
sy
:=
y0
,
sp
.
Y
;
y
!=
y1
;
y
,
sy
=
y
+
1
,
sy
+
1
{
dpix
:=
dst
.
Pix
[
y
*
dst
.
Stride
:
]
yi
:=
(
sy
-
src
.
Rect
.
Min
.
Y
)
*
src
.
YStride
+
(
sp
.
X
-
src
.
Rect
.
Min
.
X
)
ci
:=
(
sy
-
src
.
Rect
.
Min
.
Y
)
*
src
.
CStride
+
(
sp
.
X
-
src
.
Rect
.
Min
.
X
)
for
x
:=
x0
;
x
!=
x1
;
x
,
yi
,
ci
=
x
+
4
,
yi
+
1
,
ci
+
1
{
rr
,
gg
,
bb
:=
color
.
YCbCrToRGB
(
src
.
Y
[
yi
],
src
.
Cb
[
ci
],
src
.
Cr
[
ci
])
dpix
[
x
+
0
]
=
rr
dpix
[
x
+
1
]
=
gg
dpix
[
x
+
2
]
=
bb
dpix
[
x
+
3
]
=
255
}
}
case
image
.
YCbCrSubsampleRatio422
:
for
y
,
sy
:=
y0
,
sp
.
Y
;
y
!=
y1
;
y
,
sy
=
y
+
1
,
sy
+
1
{
dpix
:=
dst
.
Pix
[
y
*
dst
.
Stride
:
]
...
...
@@ -381,12 +396,11 @@ func drawYCbCr(dst *image.RGBA, r image.Rectangle, src *image.YCbCr, sp image.Po
dpix
[
x
+
3
]
=
255
}
}
default
:
// Default to 4:4:4 subsampling.
case
image
.
YCbCrSubsampleRatio440
:
for
y
,
sy
:=
y0
,
sp
.
Y
;
y
!=
y1
;
y
,
sy
=
y
+
1
,
sy
+
1
{
dpix
:=
dst
.
Pix
[
y
*
dst
.
Stride
:
]
yi
:=
(
sy
-
src
.
Rect
.
Min
.
Y
)
*
src
.
YStride
+
(
sp
.
X
-
src
.
Rect
.
Min
.
X
)
ci
:=
(
sy
-
src
.
Rect
.
Min
.
Y
)
*
src
.
CStride
+
(
sp
.
X
-
src
.
Rect
.
Min
.
X
)
ci
:=
(
sy
/
2
-
src
.
Rect
.
Min
.
Y
/
2
)
*
src
.
CStride
+
(
sp
.
X
-
src
.
Rect
.
Min
.
X
)
for
x
:=
x0
;
x
!=
x1
;
x
,
yi
,
ci
=
x
+
4
,
yi
+
1
,
ci
+
1
{
rr
,
gg
,
bb
:=
color
.
YCbCrToRGB
(
src
.
Y
[
yi
],
src
.
Cb
[
ci
],
src
.
Cr
[
ci
])
dpix
[
x
+
0
]
=
rr
...
...
@@ -395,7 +409,10 @@ func drawYCbCr(dst *image.RGBA, r image.Rectangle, src *image.YCbCr, sp image.Po
dpix
[
x
+
3
]
=
255
}
}
default
:
return
false
}
return
true
}
func
drawGlyphOver
(
dst
*
image
.
RGBA
,
r
image
.
Rectangle
,
src
*
image
.
Uniform
,
mask
*
image
.
Alpha
,
mp
image
.
Point
)
{
...
...
src/pkg/image/jpeg/reader_test.go
View file @
5abf4bdc
...
...
@@ -21,6 +21,7 @@ func TestDecodeProgressive(t *testing.T) {
"../testdata/video-001"
,
"../testdata/video-001.q50.420"
,
"../testdata/video-001.q50.422"
,
"../testdata/video-001.q50.440"
,
"../testdata/video-001.q50.444"
,
"../testdata/video-005.gray.q50"
,
}
...
...
src/pkg/image/testdata/video-001.q50.440.jpeg
0 → 100644
View file @
5abf4bdc
3.58 KB
src/pkg/image/testdata/video-001.q50.440.progressive.jpeg
0 → 100644
View file @
5abf4bdc
3.45 KB
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment