From 7c167f270826039590af43360b9fb9b2890fe13d Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick <bradfitz@golang.org> Date: Fri, 30 Oct 2015 13:33:28 -0700 Subject: [PATCH] test: disable flaky heapsampling test for now Flaky tests do more harm than good. Updates #13098 Change-Id: I179ed810b49bbb96c8df462bfa20b70231b26772 Reviewed-on: https://go-review.googlesource.com/16521 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> --- test/heapsampling.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/heapsampling.go b/test/heapsampling.go index d5ffc7f202..7461a76145 100644 --- a/test/heapsampling.go +++ b/test/heapsampling.go @@ -25,6 +25,8 @@ var a64k *[64 * 1024]byte // vary for run to run. This test only checks that the resulting // values appear reasonable. func main() { + return // TODO: fix this flaky test; golang.org/issue/13098 + const countInterleaved = 10000 allocInterleaved(countInterleaved) checkAllocations(getMemProfileRecords(), "main.allocInterleaved", countInterleaved, []int64{256 * 1024, 1024, 256 * 1024, 512, 256 * 1024, 256}) -- 2.30.9