Commit 84f53339 authored by Russ Cox's avatar Russ Cox

runtime: apply comments from CL 3742

I asked for this in CL 3742 and it was ignored.

Change-Id: I30ad05f87c7d9eccb11df7e19288e3ed2c7e2e3f
Reviewed-on: https://go-review.googlesource.com/6930Reviewed-by: default avatarDmitry Vyukov <dvyukov@google.com>
parent 12079aca
...@@ -176,10 +176,10 @@ func newdefer(siz int32) *_defer { ...@@ -176,10 +176,10 @@ func newdefer(siz int32) *_defer {
} }
unlock(&sched.deferlock) unlock(&sched.deferlock)
} }
if ln := len(pp.deferpool[sc]); ln > 0 { if n := len(pp.deferpool[sc]); n > 0 {
d = pp.deferpool[sc][ln-1] d = pp.deferpool[sc][n-1]
pp.deferpool[sc][ln-1] = nil pp.deferpool[sc][n-1] = nil
pp.deferpool[sc] = pp.deferpool[sc][:ln-1] pp.deferpool[sc] = pp.deferpool[sc][:n-1]
} }
} }
if d == nil { if d == nil {
...@@ -228,10 +228,10 @@ func freedefer(d *_defer) { ...@@ -228,10 +228,10 @@ func freedefer(d *_defer) {
// Transfer half of local cache to the central cache. // Transfer half of local cache to the central cache.
var first, last *_defer var first, last *_defer
for len(pp.deferpool[sc]) > cap(pp.deferpool[sc])/2 { for len(pp.deferpool[sc]) > cap(pp.deferpool[sc])/2 {
ln := len(pp.deferpool[sc]) n := len(pp.deferpool[sc])
d := pp.deferpool[sc][ln-1] d := pp.deferpool[sc][n-1]
pp.deferpool[sc][ln-1] = nil pp.deferpool[sc][n-1] = nil
pp.deferpool[sc] = pp.deferpool[sc][:ln-1] pp.deferpool[sc] = pp.deferpool[sc][:n-1]
if first == nil { if first == nil {
first = d first = d
} else { } else {
......
...@@ -192,10 +192,10 @@ func acquireSudog() *sudog { ...@@ -192,10 +192,10 @@ func acquireSudog() *sudog {
pp.sudogcache = append(pp.sudogcache, new(sudog)) pp.sudogcache = append(pp.sudogcache, new(sudog))
} }
} }
ln := len(pp.sudogcache) n := len(pp.sudogcache)
s := pp.sudogcache[ln-1] s := pp.sudogcache[n-1]
pp.sudogcache[ln-1] = nil pp.sudogcache[n-1] = nil
pp.sudogcache = pp.sudogcache[:ln-1] pp.sudogcache = pp.sudogcache[:n-1]
if s.elem != nil { if s.elem != nil {
throw("acquireSudog: found s.elem != nil in cache") throw("acquireSudog: found s.elem != nil in cache")
} }
...@@ -230,10 +230,10 @@ func releaseSudog(s *sudog) { ...@@ -230,10 +230,10 @@ func releaseSudog(s *sudog) {
// Transfer half of local cache to the central cache. // Transfer half of local cache to the central cache.
var first, last *sudog var first, last *sudog
for len(pp.sudogcache) > cap(pp.sudogcache)/2 { for len(pp.sudogcache) > cap(pp.sudogcache)/2 {
ln := len(pp.sudogcache) n := len(pp.sudogcache)
p := pp.sudogcache[ln-1] p := pp.sudogcache[n-1]
pp.sudogcache[ln-1] = nil pp.sudogcache[n-1] = nil
pp.sudogcache = pp.sudogcache[:ln-1] pp.sudogcache = pp.sudogcache[:n-1]
if first == nil { if first == nil {
first = p first = p
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment