cmd/vet/all: delete

The work of running full vet on std and cmd during local development
has moved to go test, which of course runs during all.bash.

For errors in other GOOS/GOARCH combinations, the misc-compile
builders (running buildall.bash) also now run go vet std cmd.

The vetall builder need not do anything anymore.
Make it a no-op until it can be retired, and remove
cmd/vet/all and its special case in the go command.

Fixes #31916.

Change-Id: I8f30d184c382ea7c2c8f520e5618f680db633968
Reviewed-on: https://go-review.googlesource.com/c/go/+/176440
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

src/cmd/dist/test.go

@@ -383,22 +383,6 @@ func (t *tester) registerRaceBenchTest(pkg string) {
 var stdOutErrAreTerminals func() bool
 
 func (t *tester) registerTests() {
-	if strings.HasSuffix(os.Getenv("GO_BUILDER_NAME"), "-vetall") {
-		// Run vet over std and cmd and call it quits.
-		for k := range cgoEnabled {
-			osarch := k
-			t.tests = append(t.tests, distTest{
-				name:    "vet/" + osarch,
-				heading: "cmd/vet/all",
-				fn: func(dt *distTest) error {
-					t.addCmd(dt, "src/cmd/vet/all", "go", "run", "main.go", "-p="+osarch)
-					return nil
-				},
-			})
-		}
-		return
-	}
-
 	// Fast path to avoid the ~1 second of `go list std cmd` when
 	// the caller lists specific tests to run. (as the continuous
 	// build coordinator does).

src/cmd/go/internal/modload/init.go

@@ -357,7 +357,7 @@ func InitMod() {
 func modFileToBuildList() {
 	Target = modFile.Module.Mod
 	targetPrefix = Target.Path
-	if rel := search.InDir(cwd, cfg.GOROOTsrc); rel != "" && rel != filepath.FromSlash("cmd/vet/all") {
+	if rel := search.InDir(cwd, cfg.GOROOTsrc); rel != "" {
 		targetInGorootSrc = true
 		if Target.Path == "std" {
 			targetPrefix = ""

src/cmd/vet/all/whitelist/all.txt

-// Non-platform-specific vet whitelist. See readme.txt for details.
-
-// Compiler tests that make sure even vet-failing code adheres to the spec.
-cmd/compile/internal/gc/testdata/arithConst_test.go: a (64 bits) too small for shift of 4294967296
-cmd/compile/internal/gc/testdata/arithConst_test.go: a (64 bits) too small for shift of 4294967296
-cmd/compile/internal/gc/testdata/arithConst_test.go: a (32 bits) too small for shift of 4294967295
-cmd/compile/internal/gc/testdata/arithConst_test.go: a (32 bits) too small for shift of 4294967295
-cmd/compile/internal/gc/testdata/arithConst_test.go: a (16 bits) too small for shift of 65535
-cmd/compile/internal/gc/testdata/arithConst_test.go: a (16 bits) too small for shift of 65535
-cmd/compile/internal/gc/testdata/arithConst_test.go: a (8 bits) too small for shift of 255
-cmd/compile/internal/gc/testdata/arithConst_test.go: a (8 bits) too small for shift of 255
-cmd/compile/internal/gc/testdata/arith_test.go: x (64 bits) too small for shift of 100
-cmd/compile/internal/gc/testdata/arith_test.go: int32(x) (32 bits) too small for shift of 4294967295
-cmd/compile/internal/gc/testdata/arith_test.go: int16(x) (16 bits) too small for shift of 65535
-cmd/compile/internal/gc/testdata/arith_test.go: int8(x) (8 bits) too small for shift of 255
-cmd/compile/internal/gc/testdata/arith_test.go: w (32 bits) too small for shift of 32
-cmd/compile/internal/gc/testdata/break_test.go: unreachable code
-cmd/compile/internal/gc/testdata/break_test.go: unreachable code
-cmd/compile/internal/gc/testdata/namedReturn_test.go: self-assignment of t to t
-cmd/compile/internal/gc/testdata/short_test.go: unreachable code

src/cmd/vet/all/whitelist/readme.txt

-This directory contains whitelists for vet complaints about the standard library and commands.
-They are line-based and unordered, although counts of duplicated lines matter.
-Each line matches vet's output, except that line numbers are removed to avoid churn.
-There are also os-, arch-, and bitwidth-specific whitelists.