Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
go
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
go
Commits
9ad14c94
Commit
9ad14c94
authored
Nov 06, 2009
by
Russ Cox
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
expand "this is not just mercurial" section
R=r CC=go-dev
http://go/go-review/1024008
parent
38a41eec
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
33 additions
and
8 deletions
+33
-8
doc/contribute.html
doc/contribute.html
+33
-8
No files found.
doc/contribute.html
View file @
9ad14c94
...
@@ -173,24 +173,51 @@ Once your new code is tested and working,
...
@@ -173,24 +173,51 @@ Once your new code is tested and working,
it's time to get it reviewed and submitted.
it's time to get it reviewed and submitted.
</p>
</p>
<h2>
Installing the code review extension
</h2>
<h2>
Code review
</h2>
<p>
<p>
Changes to Go must be reviewed before they are submitted,
Changes to Go must be reviewed before they are submitted,
no matter who makes the change.
no matter who makes the change.
(In exceptional cases, such as fixing a build, the review can
follow shortly after submitting.)
A Mercurial extension helps manage the code review process.
A Mercurial extension helps manage the code review process.
The extension is included in the Go source tree but needs
The extension is included in the Go source tree but needs
to be added to your Mercurial configuration.
to be added to your Mercurial configuration.
</p>
</p>
<h3>
Caveat for Mercurial aficionados
</h3>
<p>
<p>
<i>
Using Mercurial with the code review extension is not the same
<i>
Using Mercurial with the code review extension is not the same
as using it normally.
</i>
as using standard Mercurial.
</i>
</p>
<p>
The Go repository is maintained as a single line of reviewed changes;
we prefer to avoid the complexity of Mercurial's arbitrary change graph.
The code review extension helps here: its
<code>
hg submit
</code>
command
automatically checks for and warns about the local repository
being out of date compared to the remote one.
The
<code>
hg submit
</code>
command also verifies other
properties about the Go repository.
For example,
it checks that Go code being checked in is formatted in the standard style,
as defined by
<a
href=
"/cmd/gofmt"
>
gofmt
</a>
,
and it checks that the author of the code is properly recorded for
<a
href=
"#copyright"
>
copyright purposes
</a>
.
</p>
</p>
<p>
<p>
TODO(rsc): note here about model being different.
To help ensure changes are only created by
<code>
hg submit
</code>
,
Do not use
<code>
hg commit
</code>
if you are using the Mercurial extension.
the code review extension disables the standard
<code>
hg commit
</code>
command.
</p>
<p>
Mercurial power users: To allow Go contributors to take advantage of
Mercurial's functionality for local revision control, it might be interesting
to explore how the code review extension can be made to work alongside
the Mercurial Queues extension.
</p>
</p>
<h3>
Configure the extension
</h3>
<h3>
Configure the extension
</h3>
...
@@ -232,7 +259,7 @@ Saving authentication cookies to /Users/rsc/.codereview_upload_cookies_coderevie
...
@@ -232,7 +259,7 @@ Saving authentication cookies to /Users/rsc/.codereview_upload_cookies_coderevie
<p>
Edit your
<a
href=
"http://codereview.prom.corp.google.com/settings"
>
code review settings
</a>
.
<p>
Edit your
<a
href=
"http://codereview.prom.corp.google.com/settings"
>
code review settings
</a>
.
Grab a nickname.
Grab a nickname.
Many people refer to set the Context option to
Many people
p
refer to set the Context option to
“
Whole file
”
to see more context when reviewing changes.
“
Whole file
”
to see more context when reviewing changes.
</p>
</p>
...
@@ -241,7 +268,7 @@ can use that nickname as a shorthand for naming reviewers and the CC list.
...
@@ -241,7 +268,7 @@ can use that nickname as a shorthand for naming reviewers and the CC list.
For example,
<code>
rsc
</code>
is an alias for
<code>
rsc@golang.org
</code>
.
For example,
<code>
rsc
</code>
is an alias for
<code>
rsc@golang.org
</code>
.
</p>
</p>
<h
2>
Changing code
</h2
>
<h
3>
Make a change
</h3
>
<p>
<p>
The entire checked-out tree is writable.
The entire checked-out tree is writable.
...
@@ -255,8 +282,6 @@ or
...
@@ -255,8 +282,6 @@ or
<code>
hg mv
</code>
.
<code>
hg mv
</code>
.
</p>
</p>
<h3>
Create a change
</h3>
<p>
When you are ready to send a change out for review, run
</p>
<p>
When you are ready to send a change out for review, run
</p>
<pre>
<pre>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment