Commit a3d4655c authored by Filippo Valsorda's avatar Filippo Valsorda

crypto/x509: fix value ownership in isSSLPolicy on macOS

CFDictionaryGetValueIfPresent does not take ownership of the value, so
releasing the properties dictionary before passing the value to CFEqual
can crash. Not really clear why this works most of the time.

See https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFMemoryMgmt/Concepts/Ownership.html

Fixes #28092
Hopefully fixes #30763

Change-Id: I5ee7ca276b753a48abc3aedfb78b8af68b448dd4
Reviewed-on: https://go-review.googlesource.com/c/go/+/178537Reviewed-by: default avatarAdam Langley <agl@golang.org>
parent 06b0babf
......@@ -16,7 +16,7 @@ package x509
#include <CoreFoundation/CoreFoundation.h>
#include <Security/Security.h>
static bool isSSLPolicy(SecPolicyRef policyRef) {
static Boolean isSSLPolicy(SecPolicyRef policyRef) {
if (!policyRef) {
return false;
}
......@@ -24,13 +24,13 @@ static bool isSSLPolicy(SecPolicyRef policyRef) {
if (properties == NULL) {
return false;
}
Boolean isSSL = false;
CFTypeRef value = NULL;
if (CFDictionaryGetValueIfPresent(properties, kSecPolicyOid, (const void **)&value)) {
CFRelease(properties);
return CFEqual(value, kSecPolicyAppleSSL);
isSSL = CFEqual(value, kSecPolicyAppleSSL);
}
CFRelease(properties);
return false;
return isSSL;
}
// sslTrustSettingsResult obtains the final kSecTrustSettingsResult value
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment