Commit b81dd1c0 authored by Than McIntosh's avatar Than McIntosh

cmd/link: disable new testpoint on mips pending investigation

Skip TestMinusRSymsWithSameName testpoint on MIPS for the time being
since it triggers failures on that arch. Will re-enable once the
problems are fixed.

Updates #35779.

Change-Id: I3e6650158ab04a2be77e3db5a5194df3bbb0859e
Reviewed-on: https://go-review.googlesource.com/c/go/+/208557Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
parent 6f7b96f6
...@@ -13,6 +13,7 @@ import ( ...@@ -13,6 +13,7 @@ import (
"os" "os"
"os/exec" "os/exec"
"path/filepath" "path/filepath"
"runtime"
"strings" "strings"
"testing" "testing"
) )
...@@ -132,12 +133,18 @@ int Cfunc2() { return blah(); } ...@@ -132,12 +133,18 @@ int Cfunc2() { return blah(); }
// TestMinusRSymsWithSameName tests a corner case in the new // TestMinusRSymsWithSameName tests a corner case in the new
// loader. Prior to the fix this failed with the error 'loadelf: // loader. Prior to the fix this failed with the error 'loadelf:
// $WORK/b001/_pkg_.a(ldr.syso): duplicate symbol reference: blah in // $WORK/b001/_pkg_.a(ldr.syso): duplicate symbol reference: blah in
// both main(.text) and main(.text)' // both main(.text) and main(.text)'. See issue #35779.
func TestMinusRSymsWithSameName(t *testing.T) { func TestMinusRSymsWithSameName(t *testing.T) {
testenv.MustHaveGoBuild(t) testenv.MustHaveGoBuild(t)
testenv.MustHaveCGO(t) testenv.MustHaveCGO(t)
t.Parallel() t.Parallel()
// Skip this test on MIPS for the time being since it seems to trigger
// problems with unknown relocations.
if strings.Contains(runtime.GOARCH, "mips") {
testenv.SkipFlaky(t, 35779)
}
dir, err := ioutil.TempDir("", "go-link-TestMinusRSymsWithSameName") dir, err := ioutil.TempDir("", "go-link-TestMinusRSymsWithSameName")
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
...@@ -197,7 +204,6 @@ func TestMinusRSymsWithSameName(t *testing.T) { ...@@ -197,7 +204,6 @@ func TestMinusRSymsWithSameName(t *testing.T) {
cmd := exec.Command(goTool, "build") cmd := exec.Command(goTool, "build")
cmd.Dir = dir cmd.Dir = dir
cmd.Env = env cmd.Env = env
t.Logf("%s build", goTool)
if out, err := cmd.CombinedOutput(); err != nil { if out, err := cmd.CombinedOutput(); err != nil {
t.Logf("%s", out) t.Logf("%s", out)
t.Fatal(err) t.Fatal(err)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment