Commit bc611a31 authored by Michalis Kargakis's avatar Michalis Kargakis Committed by Rob Pike

flag: Check for Set error

Check for Set error when a boolean flag isn't explicitly given a value.

Fixes #9345

Change-Id: I97a1289f8cf27567d1a726ebe5ef167c800f357c
Reviewed-on: https://go-review.googlesource.com/1897Reviewed-by: default avatarAndrew Gerrand <adg@golang.org>
Reviewed-by: default avatarRob Pike <r@golang.org>
parent e4c2229e
...@@ -767,7 +767,9 @@ func (f *FlagSet) parseOne() (bool, error) { ...@@ -767,7 +767,9 @@ func (f *FlagSet) parseOne() (bool, error) {
return false, f.failf("invalid boolean value %q for -%s: %v", value, name, err) return false, f.failf("invalid boolean value %q for -%s: %v", value, name, err)
} }
} else { } else {
fv.Set("true") if err := fv.Set("true"); err != nil {
return false, f.failf("invalid boolean flag %s: %v", name, err)
}
} }
} else { } else {
// It must have a value, which might be the next argument. // It must have a value, which might be the next argument.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment