Commit bed7e3ed authored by Russ Cox's avatar Russ Cox

gc: fix pprof deadlock

Fixes #2051.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4834041
parent 032ffb2e
......@@ -122,6 +122,10 @@ runtime·SetCPUProfileRate(int32 hz)
uintptr *p;
uintptr n;
// Call findfunc now so that it won't have to
// build tables during the signal handler.
runtime·findfunc(0);
// Clamp hz to something reasonable.
if(hz < 0)
hz = 0;
......
......@@ -420,10 +420,19 @@ runtime·findfunc(uintptr addr)
Func *f;
int32 nf, n;
// Use atomic double-checked locking,
// because when called from pprof signal
// handler, findfunc must run without
// grabbing any locks.
// (Before enabling the signal handler,
// SetCPUProfileRate calls findfunc to trigger
// the initialization outside the handler.)
if(runtime·atomicloadp(&func) == nil) {
runtime·lock(&funclock);
if(func == nil)
buildfuncs();
runtime·unlock(&funclock);
}
if(nfunc == 0)
return nil;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment