Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
go
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
go
Commits
e4fa1e40
Commit
e4fa1e40
authored
Sep 18, 2014
by
Robert Griesemer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
go/doc: document rationale for recent change
LGTM=adg R=adg CC=golang-codereviews
https://golang.org/cl/143290043
parent
e9ec8e7a
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
1 deletion
+4
-1
src/go/doc/exports.go
src/go/doc/exports.go
+4
-1
No files found.
src/go/doc/exports.go
View file @
e4fa1e40
...
@@ -12,7 +12,8 @@ import (
...
@@ -12,7 +12,8 @@ import (
)
)
// filterIdentList removes unexported names from list in place
// filterIdentList removes unexported names from list in place
// and returns the resulting list.
// and returns the resulting list. If blankOk is set, blank
// identifiers are considered exported names.
//
//
func
filterIdentList
(
list
[]
*
ast
.
Ident
,
blankOk
bool
)
[]
*
ast
.
Ident
{
func
filterIdentList
(
list
[]
*
ast
.
Ident
,
blankOk
bool
)
[]
*
ast
.
Ident
{
j
:=
0
j
:=
0
...
@@ -145,6 +146,8 @@ func (r *reader) filterSpec(spec ast.Spec, tok token.Token) bool {
...
@@ -145,6 +146,8 @@ func (r *reader) filterSpec(spec ast.Spec, tok token.Token) bool {
// always keep imports so we can collect them
// always keep imports so we can collect them
return
true
return
true
case
*
ast
.
ValueSpec
:
case
*
ast
.
ValueSpec
:
// special case: consider blank constants as exported
// (work-around for issue 5397)
s
.
Names
=
filterIdentList
(
s
.
Names
,
tok
==
token
.
CONST
)
s
.
Names
=
filterIdentList
(
s
.
Names
,
tok
==
token
.
CONST
)
if
len
(
s
.
Names
)
>
0
{
if
len
(
s
.
Names
)
>
0
{
r
.
filterType
(
nil
,
s
.
Type
)
r
.
filterType
(
nil
,
s
.
Type
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment