Commit e4fa1e40 authored by Robert Griesemer's avatar Robert Griesemer

go/doc: document rationale for recent change

LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/143290043
parent e9ec8e7a
...@@ -12,7 +12,8 @@ import ( ...@@ -12,7 +12,8 @@ import (
) )
// filterIdentList removes unexported names from list in place // filterIdentList removes unexported names from list in place
// and returns the resulting list. // and returns the resulting list. If blankOk is set, blank
// identifiers are considered exported names.
// //
func filterIdentList(list []*ast.Ident, blankOk bool) []*ast.Ident { func filterIdentList(list []*ast.Ident, blankOk bool) []*ast.Ident {
j := 0 j := 0
...@@ -145,6 +146,8 @@ func (r *reader) filterSpec(spec ast.Spec, tok token.Token) bool { ...@@ -145,6 +146,8 @@ func (r *reader) filterSpec(spec ast.Spec, tok token.Token) bool {
// always keep imports so we can collect them // always keep imports so we can collect them
return true return true
case *ast.ValueSpec: case *ast.ValueSpec:
// special case: consider blank constants as exported
// (work-around for issue 5397)
s.Names = filterIdentList(s.Names, tok == token.CONST) s.Names = filterIdentList(s.Names, tok == token.CONST)
if len(s.Names) > 0 { if len(s.Names) > 0 {
r.filterType(nil, s.Type) r.filterType(nil, s.Type)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment