Commit ee07504d authored by Hyang-Ah Hana Kim's avatar Hyang-Ah Hana Kim

misc/cgo/testcshared: use -pie for android-L.

Also, handle the case where 'read' returns EINVAL instead of EBADF
when the descriptor is not ready. (android 4.4.4/cyanogenmod, nexus7)

Change-Id: I56c5949d27303d44a4fd0de38951b85e20cef167
Reviewed-on: https://go-review.googlesource.com/15810Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
parent 6e5ccce8
...@@ -25,7 +25,7 @@ int main(void) { ...@@ -25,7 +25,7 @@ int main(void) {
n = read(fd, buf, sizeof buf); n = read(fd, buf, sizeof buf);
if (n >= 0) if (n >= 0)
break; break;
if (errno != EBADF) { if (errno != EBADF && errno != EINVAL) {
fprintf(stderr, "BUG: read: %s\n", strerror(errno)); fprintf(stderr, "BUG: read: %s\n", strerror(errno));
return 2; return 2;
} }
......
...@@ -20,7 +20,7 @@ goarch=$(go env GOARCH) ...@@ -20,7 +20,7 @@ goarch=$(go env GOARCH)
# Directory where cgo headers and outputs will be installed. # Directory where cgo headers and outputs will be installed.
# The installation directory format varies depending on the platform. # The installation directory format varies depending on the platform.
installdir=pkg/${goos}_${goarch}_testcshared_shared installdir=pkg/${goos}_${goarch}_testcshared_shared
if [ "${goos}/${goarch}" == "android/arm" ] || [ "${goos}/${goarch}" == "darwin/amd64" ]; then if [ "${goos}/${goarch}" == "darwin/amd64" ]; then
installdir=pkg/${goos}_${goarch}_testcshared installdir=pkg/${goos}_${goarch}_testcshared
fi fi
...@@ -88,9 +88,14 @@ if [ "$goos" == "linux" ]; then ...@@ -88,9 +88,14 @@ if [ "$goos" == "linux" ]; then
fi fi
fi fi
GOGCCFLAGS=$(go env GOGCCFLAGS)
if [ "$goos" == "android" ]; then
GOGCCFLAGS="${GOGCCFLAGS} -pie"
fi
# test0: exported symbols in shared lib are accessible. # test0: exported symbols in shared lib are accessible.
# TODO(iant): using _shared here shouldn't really be necessary. # TODO(iant): using _shared here shouldn't really be necessary.
$(go env CC) $(go env GOGCCFLAGS) -I ${installdir} -o testp main0.c libgo.$libext $(go env CC) ${GOGCCFLAGS} -I ${installdir} -o testp main0.c libgo.$libext
binpush testp binpush testp
output=$(run LD_LIBRARY_PATH=. ./testp) output=$(run LD_LIBRARY_PATH=. ./testp)
...@@ -100,7 +105,7 @@ if [ "$output" != "PASS" ]; then ...@@ -100,7 +105,7 @@ if [ "$output" != "PASS" ]; then
fi fi
# test1: shared library can be dynamically loaded and exported symbols are accessible. # test1: shared library can be dynamically loaded and exported symbols are accessible.
$(go env CC) $(go env GOGCCFLAGS) -o testp main1.c -ldl $(go env CC) ${GOGCCFLAGS} -o testp main1.c -ldl
binpush testp binpush testp
output=$(run ./testp ./libgo.$libext) output=$(run ./testp ./libgo.$libext)
if [ "$output" != "PASS" ]; then if [ "$output" != "PASS" ]; then
...@@ -115,7 +120,7 @@ linkflags="-Wl,--no-as-needed" ...@@ -115,7 +120,7 @@ linkflags="-Wl,--no-as-needed"
if [ "$goos" == "darwin" ]; then if [ "$goos" == "darwin" ]; then
linkflags="" linkflags=""
fi fi
$(go env CC) $(go env GOGCCFLAGS) -o testp2 main2.c $linkflags libgo2.$libext $(go env CC) ${GOGCCFLAGS} -o testp2 main2.c $linkflags libgo2.$libext
binpush testp2 binpush testp2
output=$(run LD_LIBRARY_PATH=. ./testp2) output=$(run LD_LIBRARY_PATH=. ./testp2)
if [ "$output" != "PASS" ]; then if [ "$output" != "PASS" ]; then
...@@ -125,7 +130,7 @@ fi ...@@ -125,7 +130,7 @@ fi
# test3: tests main.main is exported on android. # test3: tests main.main is exported on android.
if [ "$goos" == "android" ]; then if [ "$goos" == "android" ]; then
$(go env CC) $(go env GOGCCFLAGS) -o testp3 main3.c -ldl $(go env CC) ${GOGCCFLAGS} -o testp3 main3.c -ldl
binpush testp3 binpush testp3
output=$(run ./testp ./libgo.so) output=$(run ./testp ./libgo.so)
if [ "$output" != "PASS" ]; then if [ "$output" != "PASS" ]; then
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment