Commit eebf7d27 authored by Yao Zhang's avatar Yao Zhang Committed by Minux Ma

net/http: fixed TestLinuxSendfile for mips64

mips64 strace doesn't support sendfile64 and will error out if we
specify that with `-e trace='. So we use sendfile for mips64 here.

Change-Id: If5e2bb39866ca3a77dcc40e4db338ba486921d89
Reviewed-on: https://go-review.googlesource.com/14455Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
parent 84df3818
...@@ -917,8 +917,16 @@ func TestLinuxSendfile(t *testing.T) { ...@@ -917,8 +917,16 @@ func TestLinuxSendfile(t *testing.T) {
} }
defer ln.Close() defer ln.Close()
syscalls := "sendfile,sendfile64"
switch runtime.GOARCH {
case "mips64", "mips64le":
// mips64 strace doesn't support sendfile64 and will error out
// if we specify that with `-e trace='.
syscalls = "sendfile"
}
var buf bytes.Buffer var buf bytes.Buffer
child := exec.Command("strace", "-f", "-q", "-e", "trace=sendfile,sendfile64", os.Args[0], "-test.run=TestLinuxSendfileChild") child := exec.Command("strace", "-f", "-q", "-e", "trace="+syscalls, os.Args[0], "-test.run=TestLinuxSendfileChild")
child.ExtraFiles = append(child.ExtraFiles, lnf) child.ExtraFiles = append(child.ExtraFiles, lnf)
child.Env = append([]string{"GO_WANT_HELPER_PROCESS=1"}, os.Environ()...) child.Env = append([]string{"GO_WANT_HELPER_PROCESS=1"}, os.Environ()...)
child.Stdout = &buf child.Stdout = &buf
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment