- 03 Mar, 2014 2 commits
-
-
Andrew Gerrand authored
R=minux.ma, r CC=golang-codereviews, golang-dev https://golang.org/cl/70650043
-
Andrew Gerrand authored
Note the installation instructions change doesn't apply here, so I had to patch this in manually instead of using release-apply. R=minux.ma, r CC=golang-codereviews, golang-dev https://golang.org/cl/69860047
-
- 28 Feb, 2014 5 commits
-
-
Russ Cox authored
This CL is not exactly a copy of the original quoted below. This CL omits the changes made to mgc0.c in the original. Those changes do not apply cleanly to the Go 1.2 tree, and they were cosmetic, simplifying code that was already doing the right thing. To double-check that omitting the mgc0.c change has not invalidated the fix, I have verified by hand that the test program in issue 6946 fails without this CL and passes with this CL. ««« CL 41640043 / e4c381446b48 runtime: fix crash in runtime.GoroutineProfile This is a possible Go 1.2.1 candidate. Fixes #6946. R=iant, r CC=golang-dev https://golang.org/cl/41640043 »»» LGTM=adg R=adg CC=golang-codereviews, golang-dev, iant, r https://golang.org/cl/68820045
-
Russ Cox authored
««« CL 49580044 / 38cd458b1dfe runtime: if traceback sees a breakpoint, don't change the PC Changing the PC confuses gdb, because execution does not continue where gdb expects it. Not changing the PC has the potential to confuse a stack dump, but when running under gdb it seems better to confuse a stack dump than to confuse gdb. Fixes #6776. LGTM=rsc R=golang-codereviews, dvyukov, rsc CC=golang-codereviews https://golang.org/cl/49580044 »»» LGTM=r R=golang-codereviews, r CC=golang-dev https://golang.org/cl/69800043
-
Russ Cox authored
««« CL 52090045 / 302bdb5b08b1 runtime: fix data race in GC Fixes #5139. Update #7065. R=golang-codereviews, bradfitz, minux.ma CC=golang-codereviews https://golang.org/cl/52090045 »»» LGTM=r R=golang-codereviews, r CC=golang-dev https://golang.org/cl/69790043
-
Russ Cox authored
««« CL 49490043 / 7ecbc2b8ec97 net: ignore some errors in windows Accept Fixes #6987 R=golang-codereviews, dvyukov CC=golang-codereviews https://golang.org/cl/49490043 »»» LGTM=r R=golang-codereviews, r CC=golang-dev https://golang.org/cl/69780044
-
Russ Cox authored
««« CL 40410043 / 8a7ac002f840 database/sql: Use all connections in pool The last connection in the pool was not being handed out correctly. R=golang-codereviews, gobot, bradfitz CC=golang-codereviews https://golang.org/cl/40410043 »»» LGTM=r R=golang-codereviews, r CC=golang-dev https://golang.org/cl/68820044
-
- 28 Nov, 2013 5 commits
-
-
Andrew Gerrand authored
R=golang-dev CC=golang-dev https://golang.org/cl/34820044
-
Andrew Gerrand authored
««« CL 30900044 / 65bf677ab8d8 doc/install.html: fix a tag. R=golang-dev, adg CC=golang-dev https://golang.org/cl/30900044 »»» R=golang-dev CC=golang-dev https://golang.org/cl/34860044
-
Andrew Gerrand authored
««« CL 31770043 / 286f0ddb799b misc/vim: describe how to get gofmt-on-save behaviour. Fixes #6826. R=golang-dev, bradfitz, adg CC=golang-dev https://golang.org/cl/31770043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/34960043
-
Andrew Gerrand authored
««« CL 28500043 / 1140207a3395 README: Fix installation instructions They were out of date and should refer to the source installation instructions. Fixes #6783. R=golang-dev, rsc, adg, dave CC=golang-dev https://golang.org/cl/28500043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/34880045
-
Andrew Gerrand authored
««« CL 28700043 / 8b3699321603 doc: update installation instructions Clarify that GOROOT should only be set when using a custom install path. Remove NetBSD from binary install page (we don't provide binaries). Remove "What's next" links from installation instructions. Emphasize "How to Write Go Code" page. Fixes #6613. R=golang-dev, r CC=golang-dev https://golang.org/cl/28700043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/34950043
-
- 18 Nov, 2013 5 commits
-
-
Andrew Gerrand authored
R=dsymonds CC=golang-dev https://golang.org/cl/28140043
-
Andrew Gerrand authored
««« CL 27000043 / c8d3de543c1b C: add Marko Mikulicic (Google CLA) R=golang-dev, crawshaw CC=golang-dev https://golang.org/cl/27000043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/28130043
-
Andrew Gerrand authored
««« CL 26170043 / b1edf8faa5d6 doc/asm: more about SP, ARM R11 Also rename URL to /doc/asm. R=golang-dev, minux.ma, r CC=golang-dev https://golang.org/cl/26170043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/28120043
-
Andrew Gerrand authored
««« CL 22770044 / 23fc3139589c encoding/gob: do not use MarshalText, UnmarshalText This seems to be the best of a long list of bad ways to fix this issue. Fixes #6760. R=r CC=golang-dev https://golang.org/cl/22770044 »»» R=golang-dev CC=golang-dev https://golang.org/cl/28110043
-
Andrew Gerrand authored
««« CL 26220045 / d76ade89413f encoding/gob: expose encode/decode example R=golang-dev, r CC=golang-dev https://golang.org/cl/26220045 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25380044
-
- 13 Nov, 2013 20 commits
-
-
Andrew Gerrand authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/25420045
-
Andrew Gerrand authored
««« CL 18430044 / 1a86e8314ff5 src/cmd/?a: link to new assembler document Blocked on 20930043, the CL the new text references. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/18430044 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25480046
-
Andrew Gerrand authored
««« CL 20930043 / 5a585f237d28 doc/asm.html: new document, a brief guide to the assembler Fixes #6060 R=golang-dev, iant, bradfitz, josharian, minux.ma, aram, rsc CC=golang-dev https://golang.org/cl/20930043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25820043
-
Andrew Gerrand authored
««« CL 14415043 / 4daa80747394 spec: clarify rules for blank identifiers This documents the status quo more precisely. Not a language change. Fixes #6006. R=r, rsc, iant, ken CC=golang-dev https://golang.org/cl/14415043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25790043
-
Andrew Gerrand authored
««« CL 25670043 / b7308814101a doc: use the same wording for OS X as the other OSes I used "and above" when I should have said "or later". Sorry for the churn. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/25670043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25780043
-
Andrew Gerrand authored
««« CL 25370045 / d809ded6f335 doc: we support all recent versions of OS X R=golang-dev, r CC=golang-dev https://golang.org/cl/25370045 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25580044
-
Andrew Gerrand authored
««« CL 25360043 / 37afbf6361e2 CONTRIBUTORS: add additional e-mail address for Richard Musiol R=adonovan CC=golang-dev https://golang.org/cl/25360043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25770043
-
Andrew Gerrand authored
««« CL 25350043 / d3cc963320cd A+C: Richard Musiol (individual CLA) Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/25350043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25670044
-
Andrew Gerrand authored
««« CL 22940044 / 39c724dd7f25 misc/vim: add a gofmt_command flag for :Fmt R=dsymonds, dominik.honnef, n13m3y3r, rsc, kamil.kisiel CC=golang-dev https://golang.org/cl/22940044 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25760043
-
Andrew Gerrand authored
««« CL 23940043 / 6ad0ec54cf2d cmd/godoc: document package-level examples Fixes issue 5807 . R=golang-dev, adg CC=golang-dev https://golang.org/cl/23940043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25500045
-
Andrew Gerrand authored
««« CL 20100043 / 9fe43a708b89 misc/emacs: various cleanups - Use #' for function symbols - Remove unused variables - Use declare-function to shut up byte compiler This is identical to CL 19010044 with one exception: Making sure it doesn't break on Emacs 22.1 R=adonovan, bradfitz, shendaras CC=golang-dev https://golang.org/cl/20100043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25750043
-
Andrew Gerrand authored
[release-branch.go1.2] emacs: allow users to customize the gofmt command, in particular, to use goimports instead. ««« CL 23680043 / 341a490e4736 emacs: allow users to customize the gofmt command, in particular, to use goimports instead. R=adonovan CC=golang-dev https://golang.org/cl/23680043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25740043
-
Andrew Gerrand authored
««« CL 22840043 / e6794866ebeb cmd/cgo: fix handling of array of pointers when using clang Clang does not record the "size" field for pointer types, so we must insert the size ourselves. We were already doing this, but only for the case of pointer types. For an array of pointer types, the setting of the size for the nested pointer type was happening after the computation of the size of the array type, meaning that the array type was always computed as 0 bytes. Delay the size computation. This bug happens on all Clang systems, not just FreeBSD. Our test checked that cgo wrote something, not that it was correct. FreeBSD's default clang rejects array[0] as a C struct field, so it noticed the incorrect sizes. But the sizes were incorrect everywhere. Update testcdefs to check the output has the right semantics. Fixes #6292. R=golang-dev, iant CC=golang-dev https://golang.org/cl/22840043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25460046
-
Andrew Gerrand authored
««« CL 22510043 / 77e77f508509 doc: update note about GCC 4.8.2 in gccgo instructions R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/22510043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25730043
-
Andrew Gerrand authored
««« CL 21130043 / 0685a9549d5a go/doc: add full stop of Japanese, Chinese and Korean. This fix will show a good synopsis on package listings in that languages. R=adg, r CC=golang-dev https://golang.org/cl/21130043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25720043
-
Andrew Gerrand authored
««« CL 21790043 / cbbdbdf908b9 A+C: Ato Araki (individual CLA) Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/21790043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25640046
-
Andrew Gerrand authored
««« CL 21770043 / ae58065f7dff doc/go1.2: link to cgo documentation I know it's linked in the previous sentence, but this new link is where I want it to be while reading this sentence. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/21770043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25640045
-
Andrew Gerrand authored
««« CL 21450043 / e081962da65c net/textproto: fix CanonicalMIMEHeaderKey panic Fixes #6712 R=golang-dev, adg, rsc CC=golang-dev https://golang.org/cl/21450043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25640044
-
Andrew Gerrand authored
««« CL 21390044 / dc2762a9130d C: add Robert Snedegar (Google CLA) R=golang-dev CC=golang-dev https://golang.org/cl/21390044 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25420044
-
Andrew Gerrand authored
««« CL 19990045 / 78cebfb89b21 C: add Brad Garcia (Google CLA) R=golang-dev, rsc CC=golang-dev https://golang.org/cl/19990045 »»» R=golang-dev CC=golang-dev https://golang.org/cl/25700044
-
- 01 Nov, 2013 3 commits
-
-
Andrew Gerrand authored
R=golang-dev, nigeltao CC=golang-dev https://golang.org/cl/19560047
-
Andrew Gerrand authored
««« CL 19910044 / 9eb64f5ef3a6 cmd/5l, runtime: fix divide for profiling tracebacks on ARM Two bugs: 1. The first iteration of the traceback always uses LR when provided, which it is (only) during a profiling signal, but in fact LR is correct only if the stack frame has not been allocated yet. Otherwise an intervening call may have changed LR, and the saved copy in the stack frame should be used. Fix in traceback_arm.c. 2. The division runtime call adds 8 bytes to the stack. In order to keep the traceback routines happy, it must copy the saved LR into the new 0(SP). Change SUB $8, SP into MOVW 0(SP), R11 // r11 is temporary, for use by linker MOVW.W R11, -8(SP) to update SP and 0(SP) atomically, so that the traceback always sees a saved LR at 0(SP). Fixes #6681. R=golang-dev, r CC=golang-dev https://golang.org/cl/19910044 »»» R=golang-dev CC=golang-dev https://golang.org/cl/20170048
-
Andrew Gerrand authored
««« CL 19840043 / 938b64b0f608 doc/go1.2.html: delete repeated word TBR=rsc R=golang-dev CC=golang-dev https://golang.org/cl/19840043 »»» R=golang-dev CC=golang-dev https://golang.org/cl/20240044
-