Commits · weekly.2011-11-08 · Kirill Smelkov / go

08 Nov, 2011 7 commits

weekly.2011-11-08 · 4b39d115
Andrew Gerrand authored Nov 09, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/5351049
```
4b39d115

Andrew Balholm authored Nov 09, 2011

Pass tests1.dat, test 90:
<p><image></p>

| <html>
|   <head>
|   <body>
|     <p>
|       <img>

Also pass test 91:
<a><table><a></table><p><a><div><a>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5339052

ce4eec2e

text/template: make redefinition of a template in a set more consistent. · 3e94e757

Rob Pike authored Nov 08, 2011

Also make it agree with the documentation. You get an error, unless you're
calling Add explicitly, in which case it panics since that's almost certainly
a bug. The discrepancy was caused by a panic that wasn't turned into
an error along one path; deleted the offending function for clarity.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5354045

3e94e757

runtime: add timespec definition for freebsd · 0e5cd9d3
Joel Sing authored Nov 08, 2011
```
R=golang-dev, devon.odell
CC=golang-dev
https://golang.org/cl/5340058
```
0e5cd9d3
os, syscall: fix Plan 9 build · cabe0e6a
Anthony Martin authored Nov 08, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5330067
```
cabe0e6a

html: parse <body>, <base>, <link>, <meta>, and <title> tags inside page body · f2b602ed

Andrew Balholm authored Nov 08, 2011

Pass tests1.dat, test 87:
<body><body><base><link><meta><title><p></title><body><p></body>

| <html>
|   <head>
|   <body>
|     <base>
|     <link>
|     <meta>
|     <title>
|       "<p>"
|     <p>

Handling the last <body> tag requires correcting the original insertion mode in useTheRulesFor.

Also pass test 88:
<textarea><p></textarea>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5364047

f2b602ed

runtime: add windows callback tests · b776b9e7

Alex Brainman authored Nov 08, 2011

Just a copy of cgo callback tests from misc/cgo/test.

R=rsc
CC=golang-dev, hectorchu
https://golang.org/cl/5331062

b776b9e7

07 Nov, 2011 17 commits

gotest: don't run examples that have no expected output · 2fcb0452
Andrew Gerrand authored Nov 08, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5364041
```
2fcb0452
html: fix typo in package docs. · 46ee09ef
Nigel Tao authored Nov 08, 2011
```
Fixes #2419.

R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5352046
```
46ee09ef
net: fix build comment · 2d89db65
Mikio Hara authored Nov 08, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5353045
```
2d89db65

gc: Clean up dostruct/stotype, detect broken fields and propagate up to... · 087bec3d

Luuk van Dijk authored Nov 07, 2011

gc: Clean up dostruct/stotype, detect broken fields and propagate up to structs and functions to supress spurious errors.

Fixes #1556.

R=rsc
CC=golang-dev
https://golang.org/cl/5351042

087bec3d

go/ast: fix bugs in SortImports · dfe03bb2

Russ Cox authored Nov 07, 2011

Tests are in gofix, since the bugs arise in rewritten ASTs.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5365043

dfe03bb2

lib9: fix windows build · 2547ad6b
Russ Cox authored Nov 07, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5362045
```
2547ad6b

lib9: add ctime · 3f4a91d7

Russ Cox authored Nov 07, 2011

ctime differs across Unix vs Plan 9 so add to portability library

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5363043

3f4a91d7

runtime/cgo: fix data declaration to be extern · 1c42db88

Russ Cox authored Nov 07, 2011

Otherwise some OS X toolchains complain about the redeclaration
of libcgo_thread_start by multiple object files.  The real definition
is in util.c.

Fixes #2167.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5364045

1c42db88

exp/ssh: improved client authentication support · 1170a646

Dave Cheney authored Nov 07, 2011

This CL adds an API for handling the various SSH
authenticaton methods. None and password continue
to be the only supported methods.

R=bradfitz, agl, n13m3y3r, rsc, cw
CC=golang-dev
https://golang.org/cl/5328045

1170a646

runtime: fix prototype for openbsd thrsleep · a1c622df

Joel Sing authored Nov 07, 2011

- Fix function prototype for thrsleep().
- Provide enums for clock identifiers.
- Provide timespec structure for use with thrsleep().

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5360042

a1c622df

gc: use HEADER_IO macro from gopack · 986ad31b

Ron Minnich authored Nov 07, 2011

Use HEADER_IO macro from gopack to read archive header
The HEADER_IO macro portably reads archive headers. The
current arsize code fails in the case of archive headers produced
on plan 9 6c and read on other systems (it's not portable).
Modify lex.c to use the portable macro
Build tested (including tests) on OSX.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5323072

986ad31b

gc: format nits · 2e1bb76f

Lucio De Re authored Nov 07, 2011

src/cmd/gc/bits.c: corrected a mistaken format;
src/cmd/gc/go.h: %E can accept uints.

R=rsc
CC=golang-dev
https://golang.org/cl/5331041

2e1bb76f

CONTRIBUTORS: add David Crawshaw's codereview account · a4ae4ce8
Russ Cox authored Nov 07, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5339047
```
a4ae4ce8
xml: allow parsing of <_> </_>. · 1371ac2f
David Crawshaw authored Nov 07, 2011
```
R=rsc, nigeltao
CC=golang-dev
https://golang.org/cl/5298061
```
1371ac2f
archive/zip: actually close file opened with OpenReader. · ad0e8b31
Dmitry Chestnykh authored Nov 07, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5341044
```
ad0e8b31

net/http: fix whitespace handling in sniffer. · 75af79b9

David Symonds authored Nov 07, 2011

A single character typo ("\n" instead of "\r") meant that
HTML data using DOS line breaks (CRLF) was not detected as HTML.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5365041

75af79b9

runtime: windows_386 sighandler to use correct g · 603d80c2
Alex Brainman authored Nov 07, 2011
```
Fixes #2403.

R=hectorchu
CC=golang-dev
https://golang.org/cl/5309071
```
603d80c2

06 Nov, 2011 3 commits
- html: be able to test more than one testdata file. · bbd173fc
  Nigel Tao authored Nov 07, 2011
```
R=andybalholm
CC=golang-dev
https://golang.org/cl/5351041
```
  bbd173fc
- gc: Better error message for range over non-receive channel. · ea9e9386
  Luuk van Dijk authored Nov 06, 2011
```
Fixes #2354

R=rsc
CC=golang-dev
https://golang.org/cl/5346044
```
  ea9e9386
- gc: Switch related errors should use plain format. · 0d6f857c
  Luuk van Dijk authored Nov 06, 2011
```
Fixes #2422.

R=rsc
CC=golang-dev
https://golang.org/cl/5353046
```
  0d6f857c
05 Nov, 2011 2 commits

math: faster Gamma · c1716337

Charles L. Dorian authored Nov 05, 2011

Having the compiler count the number of array elements speeds up Gamma from 63.7 to 56.6 ns/op.

R=rsc, golang-dev, r
CC=golang-dev
https://golang.org/cl/5362043

c1716337

gofix: avoid panic on body-less functions in netudpgroup. · c29cd8ab
David Symonds authored Nov 05, 2011
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/5347041
```
c29cd8ab

04 Nov, 2011 11 commits

test: make closedchan.go exit with failure if something fails · 7f0622e6
Ian Lance Taylor authored Nov 04, 2011
```
R=golang-dev, rsc, iant
CC=golang-dev
https://golang.org/cl/5356042
```
7f0622e6

math: improved high-angle test for Cos, Sin and Tan · 377ac335

Charles L. Dorian authored Nov 04, 2011

Maximum error for 386 is "close" (1e-14). For amd64, it's "veryclose" (4e-16).

R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5340042

377ac335

goinstall: allow packages from launchpad.net/~user branches. · cd6c7375

Jani Monoses authored Nov 04, 2011

The permitted filename characters should include ~ to allow
the names of user-owned branches in Launchpad.

R=golang-dev, rsc, n13m3y3r, gustavo
CC=golang-dev, gustavo.niemeyer
https://golang.org/cl/5280052

cd6c7375

CONTRIBUTORS: add Rietveld address for Jani Monoses · 6edfd2d3
Gustavo Niemeyer authored Nov 04, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5340046
```
6edfd2d3

html/template: wraps package template instead of exposing func Escape · a5291099

Mike Samuel authored Nov 04, 2011

This does escaping on first execution.

template.go defines the same interface elements as package template.
It requires rather more duplication of code than I'd like, but I'm
not clear how to avoid that.

Maybe instead of

    mySet.ParseGlob(...)
    template.ParseSetGlob(...)
    mySet.ParseFiles(...)
    mySet.ParseTemplateFiles(...)
    template.ParseTemplateFiles(...)

we combine these into a fileset abstraction that can be wrapped

    var fileset template.FileSet
    fileset.Glob(...)  // Load a few files by glob
    fileset.Files(...)  // Load a few {{define}}d files
    fileset.TemplateFiles(...)  // Load a few files as template bodies
    fileset.Funcs(...)  // Make the givens func available to templates
    // Do the parsing.
    set, err := fileset.ParseSet()
    // or set, err := fileset.ParseInto(set)

or provide an interface that can receive filenames and functions and
parse messages:

    type Bundle interface {
      TemplateFile(string)
      File(string)
      Funcs(FuncMap)
    }

and define template.Parse* to handle the file-system stuff and send
messages to a bundle:

    func ParseFiles(b Bundle, filenames ...string)

R=r, r
CC=golang-dev
https://golang.org/cl/5270042

a5291099

http: support Trailers in ReadRequest · b14ee23f

Brad Fitzpatrick authored Nov 04, 2011

Available after closing Request.Body.

R=adg, rsc
CC=golang-dev
https://golang.org/cl/5348041

b14ee23f

gc: detect type switch variable not used cases. · aac144b1
Luuk van Dijk authored Nov 04, 2011
```
Fixes #873
Fixes #2162

R=rsc
CC=golang-dev
https://golang.org/cl/5341043
```
aac144b1

html,bzip2,sql: rename Error methods that return error to Err · f2dc50b4

Gustavo Niemeyer authored Nov 04, 2011

There are three classes of methods/functions called Error:

a) The Error method in the just introduced error interface
b) Error methods that create or report errors (http.Error, etc)
c) Error methods that return errors previously associated with
   the receiver (Tokenizer.Error, rows.Error, etc).

This CL introduces the convention that methods in case (c)
should be named Err.

The reasoning for the change is:

- The change differentiates the two kinds of APIs based on
  names rather than just on signature, unloading Error a bit
- Err is closer to the err variable name that is so commonly
  used with the intent of verifying an error
- Err is shorter and thus more convenient to be used often
  on error verifications, such as in iterators following the
  convention of the sql package.

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5327064

f2dc50b4

template: format error with pointer receiver. · 39fcca60

David Symonds authored Nov 04, 2011

This is a continuation of 982d70c6d5d6.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5348042

39fcca60

runtime: fix linux/arm nanotime? · 7f5ae484
Russ Cox authored Nov 04, 2011
```
TBR=r
CC=golang-dev
https://golang.org/cl/5354041
```
7f5ae484
template: format errors · e73680ae
Russ Cox authored Nov 04, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5340043
```
e73680ae