• Al Viro's avatar
    m68k: Leave stack mangling to asm wrapper of sigreturn() · 0d20abde
    Al Viro authored
    sigreturn has to deal with an unpleasant problem - exception stack frames
    have different sizes, depending upon the exception (and processor model, as
    well) and variable-sized part of exception frame may contain information
    needed for instruction restart.  So when signal handler terminates and calls
    sigreturn to resume the execution at the place where we'd been when we caught
    the signal, it has to rearrange the frame at the bottom of kernel stack.
    Worse, it might need to open a gap in the kernel stack, shifting pt_regs
    towards lower addresses.
    
    Doing that from C is insane - we'd need to shift stack frames (return addresses,
    local variables, etc.) of C call chain, right under the nose of compiler and
    hope it won't fall apart horribly.  What had been actually done is only slightly
    less insane - an inline asm in mangle_kernel_stack() moved the stuff around,
    then reset stack pointer and jumped to label in asm glue.
    
    However, we can avoid all that mess if the asm wrapper we have to use anyway
    would reserve some space on the stack between switch_stack and the C stack
    frame of do_{rt_,}sigreturn().   Then C part can simply memmove() pt_regs +
    switch_stack, memcpy() the variable part of exception frame into the opened
    gap - all of that without inline asm, buggering C call chain, magical jumps
    to asm labels, etc.
    
    Asm wrapper would need to know where the moved switch_stack has ended up -
    it might have been shifted into the gap we'd reserved before do_rt_sigreturn()
    call.  That's where it needs to set the stack pointer to.  So let the C part
    return just that and be done with that.
    
    While we are at it, the call of berr_040cleanup() we need to do when
    returning via 68040 bus error exception frame can be moved into C part
    as well.
    Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    Tested-by: default avatarMichael Schmitz <schmitzmic@gmail.com>
    Reviewed-by: default avatarMichael Schmitz <schmitzmic@gmail.com>
    Tested-by: default avatarFinn Thain <fthain@linux-m68k.org>
    Link: https://lore.kernel.org/r/YP2dTQPm1wGPWFgD@zeniv-ca.linux.org.ukSigned-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    0d20abde
entry.S 5.19 KB