• Ingo Molnar's avatar
    sched: prevent divide by zero error in cpu_avg_load_per_task, update · af6d596f
    Ingo Molnar authored
    Regarding the bug addressed in:
    
      4cd42620: sched: prevent divide by zero error in cpu_avg_load_per_task
    
    Linus points out that the fix is not complete:
    
    > There's nothing that keeps gcc from deciding not to reload
    > rq->nr_running.
    >
    > Of course, in _practice_, I don't think gcc ever will (if it decides
    > that it will spill, gcc is likely going to decide that it will
    > literally spill the local variable to the stack rather than decide to
    > reload off the pointer), but it's a valid compiler optimization, and
    > it even has a name (rematerialization).
    >
    > So I suspect that your patch does fix the bug, but it still leaves the
    > fairly unlikely _potential_ for it to re-appear at some point.
    >
    > We have ACCESS_ONCE() as a macro to guarantee that the compiler
    > doesn't rematerialize a pointer access. That also would clarify
    > the fact that we access something unsafe outside a lock.
    
    So make sure our nr_running value is immutable and cannot change
    after we check it for nonzero.
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    af6d596f
sched.c 225 KB