• Stefan Richter's avatar
    firewire: cdev: tcodes input validation · 1f3125af
    Stefan Richter authored
    The behaviour of fw-transaction.c::fw_send_request is ill-defined for
    any other tcodes than read/ write/ lock request tcodes.  Therefore
    prevent requests with wrong tcodes from entering the transaction layer.
    
    Maybe fw_send_request should check them itself, but I am not inclined to
    change it and fw_fill_request from void-valued functions to ones which
    return error codes and pass those up.  Besides, maybe fw_send_request is
    going to support one more tcode than ioctl_send_request in the future
    (TCODE_STREAM_DATA).
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    1f3125af
fw-cdev.c 26.1 KB