• Benjamin Gray's avatar
    kasan: guard release_free_meta() shadow access with kasan_arch_is_ready() · 2597c994
    Benjamin Gray authored
    release_free_meta() accesses the shadow directly through the path
    
      kasan_slab_free
        __kasan_slab_free
          kasan_release_object_meta
            release_free_meta
              kasan_mem_to_shadow
    
    There are no kasan_arch_is_ready() guards here, allowing an oops when the
    shadow is not initialized.  The oops can be seen on a Power8 KVM guest.
    
    This patch adds the guard to release_free_meta(), as it's the first level
    that specifically requires the shadow.
    
    It is safe to put the guard at the start of this function, before the
    stack put: only kasan_save_free_info() can initialize the saved stack,
    which itself is guarded with kasan_arch_is_ready() by its caller
    poison_slab_object().  If the arch becomes ready before
    release_free_meta() then we will not observe KASAN_SLAB_FREE_META in the
    object's shadow, so we will not put an uninitialized stack either.
    
    Link: https://lkml.kernel.org/r/20240213033958.139383-1-bgray@linux.ibm.com
    Fixes: 63b85ac5 ("kasan: stop leaking stack trace handles")
    Signed-off-by: default avatarBenjamin Gray <bgray@linux.ibm.com>
    Reviewed-by: default avatarAndrey Konovalov <andreyknvl@gmail.com>
    Cc: Alexander Potapenko <glider@google.com>
    Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
    Cc: Dmitry Vyukov <dvyukov@google.com>
    Cc: Michael Ellerman <mpe@ellerman.id.au>
    Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    2597c994
generic.c 17.5 KB