• Ulf Magnusson's avatar
    kconfig: Warn if choice default is not in choice · 2c37e084
    Ulf Magnusson authored
    This will catch mistakes like in the following real-world example, where
    a "CONFIG_" prefix snuck in, making an undefined symbol the default:
    
    	choice
    		prompt "Compiler optimization level"
    		default CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE
    
    	config CC_OPTIMIZE_FOR_PERFORMANCE
    		...
    
    	config CC_OPTIMIZE_FOR_SIZE
    		...
    
    	endchoice
    
    This now prints the following warning:
    
    	init/Kconfig:1036:warning: choice default symbol 'CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE' is not contained in the choice
    
    Cases where the default symbol belongs to the wrong choice are also
    detected.
    
    (The mistake is harmless here: Since the default symbol is not visible,
    the choice falls back on using the first visible symbol as the default,
    which is CC_OPTIMIZE_FOR_PERFORMANCE, as intended.)
    
    Discovered while playing around with Kconfiglib
    (https://github.com/ulfalizer/Kconfiglib).
    Signed-off-by: default avatarUlf Magnusson <ulfalizer@gmail.com>
    Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    2c37e084
menu.c 17.8 KB