• Vladimir Oltean's avatar
    net: dsa: felix: don't drop PTP frames with tag_8021q when RX timestamping is disabled · 2edcfcbb
    Vladimir Oltean authored
    The driver implements a workaround for the fact that it doesn't have an
    IRQ source to tell it whether PTP frames are available through the
    extraction registers, for those frames to be processed and passed
    towards the network stack. That workaround is to configure the switch,
    through felix_hwtstamp_set() -> felix_update_trapping_destinations(),
    to create two copies of PTP packets: one sent over Ethernet to the DSA
    master, and one to be consumed through the aforementioned CPU extraction
    queue registers.
    
    The reason why we want PTP packets to be consumed through the CPU
    extraction registers in the first place is because we want to see their
    hardware RX timestamp. With tag_8021q, that is only visible that way,
    and it isn't visible with the copy of the packet that's transmitted over
    Ethernet.
    
    The problem with the workaround implementation is that it drops the
    packet received over Ethernet, in expectation of its copy being present
    in the CPU extraction registers. However, if felix_hwtstamp_set() hasn't
    run (aka PTP RX timestamping is disabled), the driver will drop the
    original PTP frame and there will be no copy of it in the CPU extraction
    registers. So, the network stack will simply not see any PTP frame.
    
    Look at the port's trapping configuration to see whether the driver has
    previously enabled the CPU extraction registers. If it hasn't, just
    don't RX timestamp the frame and let it be passed up the stack by DSA,
    which is perfectly fine.
    
    Fixes: 0a6f17c6 ("net: dsa: tag_ocelot_8021q: add support for PTP timestamping")
    Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
    Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
    2edcfcbb
felix.c 58.7 KB