• Linus Torvalds's avatar
    Initialize msg/shm IPC objects before doing ipc_addid() · 2ef259c0
    Linus Torvalds authored
    commit b9a53227 upstream.
    
    As reported by Dmitry Vyukov, we really shouldn't do ipc_addid() before
    having initialized the IPC object state.  Yes, we initialize the IPC
    object in a locked state, but with all the lockless RCU lookup work,
    that IPC object lock no longer means that the state cannot be seen.
    
    We already did this for the IPC semaphore code (see commit e8577d1f:
    "ipc/sem.c: fully initialize sem_array before making it visible") but we
    clearly forgot about msg and shm.
    Reported-by: default avatarDmitry Vyukov <dvyukov@google.com>
    Cc: Manfred Spraul <manfred@colorfullife.com>
    Cc: Davidlohr Bueso <dbueso@suse.de>
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    [bwh: Backported to 3.2:
     - Adjust context
     - The error path being moved looks a little different]
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    2ef259c0
msg.c 20.9 KB