• Daniel Vetter's avatar
    drm: Fix oops in damage self-tests by mocking damage property · 2f425cf5
    Daniel Vetter authored
    I've added a new check to make sure that drivers which insepct the
    damage property have it set up correctly, but somehow missed that this
    borke the damage selftest in the CI result noise.
    
    Fix it up by mocking enough of drm_device and drm_plane so we can call
    drm_plane_enable_fb_damage_clips() to make the new check happy.
    
    Since there's a lot of duplicated mock code already copy-pasted into
    each test I've also refactored this a bit to trim it down.
    
    v2: Squash in fixup from 0day for
    
    drivers/gpu/drm/selftests/test-drm_damage_helper.c:15:19: warning: symbol 'mock_device' was not declared. Should it be static?
    drivers/gpu/drm/selftests/test-drm_damage_helper.c:16:30: warning: symbol 'mock_obj_props' was not declared. Should it be static?
    drivers/gpu/drm/selftests/test-drm_damage_helper.c:17:18: warning: symbol 'mock_plane' was not declared. Should it be static?
    drivers/gpu/drm/selftests/test-drm_damage_helper.c:18:21: warning: symbol 'mock_prop' was not declared. Should it be static?
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Signed-off-by: default avatarkernel test robot <lkp@intel.com>
    Reviewed-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
    Fixes: c7fcbf25 ("drm/plane: check that fb_damage is set up when used")
    Cc: José Roberto de Souza <jose.souza@intel.com> (v1)
    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
    Cc: José Roberto de Souza <jose.souza@intel.com>
    Cc: Hans de Goede <hdegoede@redhat.com>
    Cc: Daniel Vetter <daniel.vetter@intel.com>
    Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Cc: Maxime Ripard <mripard@kernel.org>
    Cc: Thomas Zimmermann <tzimmermann@suse.de>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210730095251.4343-1-daniel.vetter@ffwll.ch
    Link: https://patchwork.freedesktop.org/patch/msgid/20210730141948.GA11955@243d74413310
    2f425cf5
test-drm_damage_helper.c 19 KB