• Christoph Hellwig's avatar
    block: move discard checks into the ioctl handler · 30f1e724
    Christoph Hellwig authored
    Most bio operations get basic sanity checking in submit_bio and anything
    more complicated than that is done in the callers.  Discards are a bit
    different from that in that a lot of checking is done in
    __blkdev_issue_discard, and the specific errnos for that are returned
    to userspace.  Move the checks that require specific errnos to the ioctl
    handler instead, and just leave the basic sanity checking in submit_bio
    for the other handlers.  This introduces two changes in behavior:
    
     1) the logical block size alignment check of the start and len is lost
        for non-ioctl callers.
        This matches what is done for other operations including reads and
        writes.  We should probably verify this for all bios, but for now
        make discards match the normal flow.
     2) for non-ioctl callers all errors are reported on I/O completion now
        instead of synchronously.  Callers in general mostly ignore or log
        errors so this will actually simplify the code once cleaned up
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    Link: https://lore.kernel.org/r/20240506042027.2289826-3-hch@lst.deSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
    30f1e724
ioctl.c 17.1 KB