• David Arcari's avatar
    platform/x86/intel/ifs: Annotate work queue on stack so object debug does not complain · 3279decb
    David Arcari authored
    Object Debug results in the following warning while attempting to load
    ifs firmware:
    
    [  220.007422] ODEBUG: object 000000003bf952db is on stack 00000000e843994b, but NOT annotated.
    [  220.007459] ------------[ cut here ]------------
    [  220.007461] WARNING: CPU: 0 PID: 11774 at lib/debugobjects.c:548 __debug_object_init.cold+0x22e/0x2d5
    [  220.137476] RIP: 0010:__debug_object_init.cold+0x22e/0x2d5
    [  220.254774] Call Trace:
    [  220.257641]  <TASK>
    [  220.265606]  scan_chunks_sanity_check+0x368/0x5f0 [intel_ifs]
    [  220.288292]  ifs_load_firmware+0x2a3/0x400 [intel_ifs]
    [  220.332793]  current_batch_store+0xea/0x160 [intel_ifs]
    [  220.357947]  kernfs_fop_write_iter+0x355/0x530
    [  220.363048]  new_sync_write+0x28e/0x4a0
    [  220.381226]  vfs_write+0x62a/0x920
    [  220.385160]  ksys_write+0xf9/0x1d0
    [  220.399421]  do_syscall_64+0x59/0x90
    [  220.440635]  entry_SYSCALL_64_after_hwframe+0x63/0xcd
    [  220.566845] ---[ end trace 3a01b299db142b41 ]---
    
    Correct this by calling INIT_WORK_ONSTACK instead of INIT_WORK.
    
    Fixes: 684ec215 ("platform/x86/intel/ifs: Authenticate and copy to secured memory")
    Signed-off-by: default avatarDavid Arcari <darcari@redhat.com>
    Cc: Jithu Joseph <jithu.joseph@intel.com>
    Cc: Ashok Raj <ashok.raj@intel.com>
    Cc: Tony Luck <tony.luck@intel.com>
    Cc: Hans de Goede <hdegoede@redhat.com>
    Cc: Mark Gross <markgross@kernel.org>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Dan Williams <dan.j.williams@intel.com>
    Cc: linux-kernel@vger.kernel.org
    Cc: stable@vger.kernel.org
    Link: https://lore.kernel.org/r/20230523105400.674152-1-darcari@redhat.comReviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    3279decb
load.c 8.38 KB