• Andrew Morton's avatar
    [PATCH] remove duplicated disk statistics · 36e573c7
    Andrew Morton authored
    This patch will break some userspace monitoring apps in the name of
    having sane disk statistics in 2.6.x.
    
    Patch from Rick Lindsley <ricklind@us.ibm.com>
    
    In 2.5.46, there are now disk statistics being collected twice: once
    for gendisk/hd_struct, and once for dkstat.  They are collecting the
    same thing.  This patch removes dkstat, which also had the disadvantage
    of being limited by DK_MAX_MAJOR and DK_MAX_DISK. (Those #defines are
    removed too.)
    
    In addition, this patch removes disk statistics from /proc/stat since
    they are now available via sysfs and there seems to have been a general
    preference in previous discussions to "clean up" /proc/stat.  Too many
    disks being reported in /proc/stat also caused buffer overflows when
    trying to print out the data.
    
    The code in led.c from the parisc architecture has not apparently been
    recompiled under recent versions of 2.5, since it references
    kstat.dk_drive which doesn't exist in later versions.  Accordingly,
    I've added an #ifdef 0 and a comment to that code so that it may at
    least compile, albeit without one feature -- a step up from its state
    now.  If it is preferable to keep the broken code in, that patch may
    easily be excised from below.
    36e573c7
led.c 19.9 KB