• Tony Krowiak's avatar
    s390/vfio-ap: No need to disable IRQ after queue reset · 6c12a638
    Tony Krowiak authored
    The queues assigned to a matrix mediated device are currently reset when:
    
    * The VFIO_DEVICE_RESET ioctl is invoked
    * The mdev fd is closed by userspace (QEMU)
    * The mdev is removed from sysfs.
    
    Immediately after the reset of a queue, a call is made to disable
    interrupts for the queue. This is entirely unnecessary because the reset of
    a queue disables interrupts, so this will be removed.
    
    Furthermore, vfio_ap_irq_disable() does an unconditional PQAP/AQIC which
    can result in a specification exception (when the corresponding facility
    is not available), so this is actually a bugfix.
    Signed-off-by: default avatarTony Krowiak <akrowiak@linux.ibm.com>
    [pasic@linux.ibm.com: minor rework before merging]
    Signed-off-by: default avatarHalil Pasic <pasic@linux.ibm.com>
    Fixes: ec89b55e ("s390: ap: implement PAPQ AQIC interception in kernel")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
    6c12a638
vfio_ap_drv.c 4.8 KB