• Lucy Mielke's avatar
    locking/lockdep: Fix string sizing bug that triggers a format-truncation compiler-warning · ac8b60be
    Lucy Mielke authored
    On an allyesconfig, with "treat warnings as errors" unset, GCC emits
    these warnings:
    
    	kernel/locking/lockdep_proc.c:438:32: Warning: Format specifier '%lld' may
    		be truncated when writing 1 to 17 bytes into a region
    		of size 15 [-Wformat-truncation=]
    
    	kernel/locking/lockdep_proc.c:438:31: Note: Format directive argument is
    		in the range [-9223372036854775, 9223372036854775]
    
    	kernel/locking/lockdep_proc.c:438:9: Note: 'snprintf' has output
    		between 5 and 22 bytes into a target of size 15
    
    In seq_time(), the longest s64 is "-9223372036854775808"-ish, which
    converted to the fixed-point float format is "-9223372036854775.80": 21 bytes,
    plus termination is another byte: 22. Therefore, a larger buffer size
    of 22 is needed here - not 15. The code was safe due to the snprintf().
    
    Fix it.
    Signed-off-by: default avatarLucy Mielke <lucymielke@icloud.com>
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    Link: https://lore.kernel.org/r/ZSfOEHRkZAWaQr3U@fedora.fritz.box
    ac8b60be
lockdep_proc.c 18.7 KB