• Jonas Dreßler's avatar
    Bluetooth: hci_conn: Only do ACL connections sequentially · 45340097
    Jonas Dreßler authored
    Pretty much all bluetooth chipsets only support paging a single device at
    a time, and if they don't reject a secondary "Create Connection" request
    while another is still ongoing, they'll most likely serialize those
    requests in the firware.
    
    With commit 4c67bc74 ("[Bluetooth] Support concurrent connect
    requests") we started adding some serialization of our own in case the
    adapter returns "Command Disallowed" HCI error.
    
    This commit was using the BT_CONNECT2 state for the serialization, this
    state is also used for a few more things (most notably to indicate we're
    waiting for an inquiry to cancel) and therefore a bit unreliable. Also
    not all BT firwares would respond with "Command Disallowed" on too many
    connection requests, some will also respond with "Hardware Failure"
    (BCM4378), and others will error out later and send a "Connect Complete"
    event with error "Rejected Limited Resources" (Marvell 88W8897).
    
    We can clean things up a bit and also make the serialization more reliable
    by using our hci_sync machinery to always do "Create Connection" requests
    in a sequential manner.
    
    This is very similar to what we're already doing for establishing LE
    connections, and it works well there.
    
    Note that this causes a test failure in mgmt-tester (test "Pair Device
    - Power off 1") because the hci_abort_conn_sync() changes the error we
    return on timeout of the "Create Connection". We'll fix this on the
    mgmt-tester side by adjusting the expected error for the test.
    Signed-off-by: default avatarJonas Dreßler <verdre@v0yd.nl>
    Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
    45340097
hci_sync.h 5.68 KB