• Tiezhu Yang's avatar
    LoongArch: Give a chance to build with !CONFIG_SMP · 5685d7fc
    Tiezhu Yang authored
    In the current code, SMP is selected in Kconfig for LoongArch, the users
    can not unset it, this is reasonable for a multi-processor machine. But
    as the help info of config SMP said, if you have a system with only one
    CPU, say N. On a uni-processor machine, the kernel will run faster if you
    say N here.
    
    Loongson-2K0500 is a single-core CPU for applications like industrial
    control, printing terminals, and BMC (Baseboard Management Controller),
    there are many development boards, products and solutions on the market,
    so it is better and necessary to give a chance to build with !CONFIG_SMP
    for a uni-processor machine.
    
    First of all, do not select SMP for config LOONGARCH in Kconfig to make
    it possible to unset CONFIG_SMP. Then, do some changes to fix warnings
    and errors if CONFIG_SMP is not set.
    
    (1) Define get_ipi_irq() only if CONFIG_SMP is set to fix the warning:
    arch/loongarch/kernel/irq.c:90:19: warning: 'get_ipi_irq' defined but not used [-Wunused-function]
    
    (2) Add "#ifdef CONFIG_SMP" in asm/smp.h to fix the warning:
    ./arch/loongarch/include/asm/smp.h:49:9: warning: "raw_smp_processor_id" redefined
       49 | #define raw_smp_processor_id raw_smp_processor_id
          |         ^~~~~~~~~~~~~~~~~~~~
    ./include/linux/smp.h:198:9: note: this is the location of the previous definition
      198 | #define raw_smp_processor_id()                  0
    
    (3) Define machine_shutdown() as empty under !CONFIG_SMP to fix the error:
    arch/loongarch/kernel/machine_kexec.c: In function 'machine_shutdown':
    arch/loongarch/kernel/machine_kexec.c:233:25: error: implicit declaration of function 'cpu_device_up'; did you mean 'put_device'? [-Wimplicit-function-declaration]
    
    (4) Make config SCHED_SMT depends on SMP to fix many errors such as:
    kernel/sched/core.c: In function 'sched_core_find':
    kernel/sched/core.c:310:43: error: 'struct rq' has no member named 'cpu'
    
    (5) Define cpu_logical_map(cpu) as 0 under !CONFIG_SMP in asm/smp.h,
    then include asm/smp.h in asm/acpi.h (because acpi.h is included in
    linux/irq.h indirectly) to fix many build errors under drivers/irqchip
    such as:
    drivers/irqchip/irq-loongson-eiointc.c: In function 'cpu_to_eio_node':
    drivers/irqchip/irq-loongson-eiointc.c:59:16: error: implicit declaration of function 'cpu_logical_map' [-Wimplicit-function-declaration]
    
    (6) Do not write per_cpu_offset(0) to PERCPU_BASE_KS when resume because
    the per_cpu_offset(x) macro is defined as (__per_cpu_offset[x]) only
    under CONFIG_SMP in include/asm-generic/percpu.h. Just save the value of
    PERCPU_BASE_KS when suspend and restore it when resume to fix the error:
    arch/loongarch/power/suspend.c: In function 'loongarch_common_resume':
    arch/loongarch/power/suspend.c:47:21: error: implicit declaration of function 'per_cpu_offset' [-Wimplicit-function-declaration]
    
    (7) Fix huge page handling under !CONFIG_SMP in tlbex.S.
    
    When running the UnixBench tests with "-c 1" single-streamed pass, the
    improvement of performance is about 9 percent with this patch.
    
    By the way, it is helpful to debug and analysis the kernel issues of
    multi-processor system under !CONFIG_SMP.
    Signed-off-by: default avatarTiezhu Yang <yangtiezhu@loongson.cn>
    Signed-off-by: default avatarHuacai Chen <chenhuacai@loongson.cn>
    5685d7fc
machine_kexec.c 7.43 KB