• Ashok Raj's avatar
    x86/microcode/intel: Do not print microcode revision and processor flags · 5b1586ab
    Ashok Raj authored
    collect_cpu_info() is used to collect the current microcode revision and
    processor flags on every CPU.
    
    It had a weird mechanism to try to mimick a "once" functionality in the
    sense that, that information should be issued only when it is differing
    from the previous CPU.
    
    However (1):
    
    the new calling sequence started doing that in parallel:
    
      microcode_init()
      |-> schedule_on_each_cpu(setup_online_cpu)
          |-> collect_cpu_info()
    
    resulting in multiple redundant prints:
    
      microcode: sig=0x50654, pf=0x80, revision=0x2006e05
      microcode: sig=0x50654, pf=0x80, revision=0x2006e05
      microcode: sig=0x50654, pf=0x80, revision=0x2006e05
    
    However (2):
    
    dumping this here is not that important because the kernel does not
    support mixed silicon steppings microcode. Finally!
    
    Besides, there is already a pr_info() in microcode_reload_late() that
    shows both the old and new revisions.
    
    What is more, the CPU signature (sig=0x50654) and Processor Flags
    (pf=0x80) above aren't that useful to the end user, they are available
    via /proc/cpuinfo and they don't change anyway.
    
    Remove the redundant pr_info().
    
      [ bp: Heavily massage. ]
    
    Fixes: b6f86689 ("x86/microcode: Rip out the subsys interface gunk")
    Reported-by: default avatarTony Luck <tony.luck@intel.com>
    Signed-off-by: default avatarAshok Raj <ashok.raj@intel.com>
    Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
    Link: https://lore.kernel.org/r/20221103175901.164783-2-ashok.raj@intel.com
    5b1586ab
intel.c 18 KB