• Vladimir Oltean's avatar
    net/sched: cls_flower: use ntohs for struct flow_dissector_key_ports · 6215afcb
    Vladimir Oltean authored
    A make W=1 build complains that:
    
    net/sched/cls_flower.c:214:20: warning: cast from restricted __be16
    net/sched/cls_flower.c:214:20: warning: incorrect type in argument 1 (different base types)
    net/sched/cls_flower.c:214:20:    expected unsigned short [usertype] val
    net/sched/cls_flower.c:214:20:    got restricted __be16 [usertype] dst
    
    This is because we use htons on struct flow_dissector_key_ports members
    src and dst, which are defined as __be16, so they are already in network
    byte order, not host. The byte swap function for the other direction
    should have been used.
    
    Because htons and ntohs do the same thing (either both swap, or none
    does), this change has no functional effect except to silence the
    warnings.
    Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    6215afcb
cls_flower.c 92 KB