• Namhyung Kim's avatar
    perf record: Fix a potential error handling issue · 73bf63a4
    Namhyung Kim authored
    
    
    The evlist is allocated at the beginning of cmd_record().  Also free-ing
    thread masks should be paired with record__init_thread_masks() which is
    called right before __cmd_record().
    
    Let's change the order of these functions to release the resources
    correctly in case of errors.  This is maybe fine as the process exits,
    but it might be a problem if it manages some system-wide resources that
    live longer than the process.
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: KP Singh <kpsingh@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Song Liu <song@kernel.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: bpf@vger.kernel.org
    Link: https://lore.kernel.org/r/20240703223035.2024586-7-namhyung@kernel.org
    
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    73bf63a4
builtin-record.c 112 KB